test_show_translates_image_state_correctly sometimes fails

[Christopher Yeoh]

Very rarely can get this failure when running the unittests

======================================================================
ERROR: nova.tests.image.test_s3.TestS3ImageService.test_show_translates_image_state_correctly
tags: worker-2
----------------------------------------------------------------------
Empty attachments:
  pythonlogging:''
  pythonlogging:'boto'
  stderr
  stdout

Traceback (most recent call last):
  File "nova/tests/image/test_s3.py", line 151, in test_show_translates_image_state_correctly
    ret_image = self.image_service.show(self.context, '1')
  File "nova/image/s3.py", line 171, in show
    image = self.service.show(context, image_uuid)
  File "nova/tests/image/test_s3.py", line 142, in my_fake_show
    'properties': {'image_state': fake_state_map[image_id]}}
KeyError: u'cedef40a-ed67-4d10-800e-17455edce175'
libvir: error : internal error could not initialize domain event timer
Ran 5689 (-8) tests in 118.504s (+1.271s)
FAILED (id=797, failures=1, skips=12)
error: testr failed (1)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27698

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27698
Committed: http://github.com/openstack/nova/commit/52d3ff067e7e145c73ef768fca5bfb71e89b054c
Submitter: Jenkins
Branch: master

commit 52d3ff067e7e145c73ef768fca5bfb71e89b054c
Author: Chris Yeoh <email address hidden>
Date: Mon Apr 29 20:18:25 2013 +0930

    Fix flakey TestS3ImageService bug

    test_show_translates_image_state_correctly sometimes fails
    on some systems. This is caused because the ec2utils cache
    is reset after the test rather than before the test (but after
    the images are manually added to the db in setUp). This change
    resets the ec2utils cache in the correct place

    Fixes bug 1174266

    Change-Id: I2ff9b71c932c913ca0423b1de4c04ca7d9de59cf