swiftclient, quantumclient, and cinderclient, are not optional

Bug #1174005 reported by Clint Byrum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Angus Salkeld

Bug Description

I see no reason to make these basic client libraries optional. They are listed in pip-requires and are equally available on any platform that has the others which are not conditionally imported. What should define whether or not swift, quantum, or cinder are available, is the keystone catalog and/or heat's configuration. I believe making them non-optional would remove all conditional import code.

Revision history for this message
Steven Hardy (shardy) wrote :

We've been trying to maintain some backwards compatibility, as we have existing users, some of which will still be using Folsom

Since we don't currently have a stable/Folsom branch, I think we need to discuss this and probably have a vote regarding the advantages and disadvantages of diverging. My feeling right now is that a few conditional imports are less-bad than the burden of doing lots of stable-branch backports.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Isn't this invalid now that requirements.txt for heat on the master branch requires all 3?

https://github.com/openstack/heat/blob/master/requirements.txt

However, python-quantumclient should be changed to python-neutronclient.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/37714

Changed in heat:
assignee: nobody → Matt Riedemann (mriedem)
status: New → In Progress
Matt Riedemann (mriedem)
Changed in heat:
assignee: Matt Riedemann (mriedem) → nobody
status: In Progress → New
Steven Dake (sdake)
Changed in heat:
milestone: none → icehouse-1
assignee: nobody → Steven Dake (sdake)
importance: Undecided → Medium
status: New → Confirmed
Changed in heat:
milestone: icehouse-1 → icehouse-2
Changed in heat:
milestone: icehouse-2 → icehouse-3
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-3 → icehouse-rc1
Changed in heat:
milestone: icehouse-rc1 → next
assignee: Steven Dake (sdake) → nobody
Angus Salkeld (asalkeld)
Changed in heat:
assignee: nobody → Angus Salkeld (asalkeld)
Changed in heat:
status: Confirmed → In Progress
Zane Bitter (zaneb)
Changed in heat:
milestone: next → juno-1
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → juno-2
milestone: juno-2 → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/92498
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=05b0ff1155004ed4bbf80213ad5bfd33d3457643
Submitter: Jenkins
Branch: master

commit 05b0ff1155004ed4bbf80213ad5bfd33d3457643
Author: Angus Salkeld <email address hidden>
Date: Fri May 30 09:39:56 2014 +1000

    Remove optional imports from clients.py

    Why:
    - These are in the requirements
    - Heat is now well down the path of been a part of the integrated release
    - All of the above clients are also integrated.
    - If someone wants to use heat on an old OpenStack they still can
      as long as they install the required recent client libraries,
      which are backwards compatible with older OpenStack releases.

    Change-Id: I39d7dcbd3e5655d3da1c97de5ff7eceb1826d4ea
    Fixes-bug: #1174005

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.