Avoid the use of unconditional except:

[Marco Giusti]

Unconditional except are bads because they hide programming errors and
prevent the application to exit in some cases. Catch only specific
exception or reraise it. Here a, maybe incomplete, list of inconditional
catch (grep -r -n except:):

 virtualbricks/virtualmachines.py:170: # except:
 virtualbricks/virtualmachines.py:186: # except:
 virtualbricks/virtualmachines.py:190: # except:
 virtualbricks/bricks.py:221: except:
 virtualbricks/bricks.py:453: except:
 virtualbricks/bricks.py:470: except:
 virtualbricks/console.py:154: except: # XXX don't catch all errors
 virtualbricks/console.py:159: except: # XXX: don't catch all errors
 virtualbricks/wires.py:132: except:
 virtualbricks/wires.py:178: except:
 virtualbricks/events.py:85: except:
 virtualbricks/events.py:186: except:
 virtualbricks/configfile.py:48: except:
 virtualbricks/configfile.py:192: except:
 virtualbricks/brickconfig.py:86: except:
 virtualbricks/settings.py:62: except:
 virtualbricks/gui/gui.py.~1~:334: except:
 virtualbricks/gui/gui.py.~1~:1816: except:
 virtualbricks/gui/gui.py.~1~:1821: except:
 virtualbricks/gui/gui.py.~1~:2803: except:
 virtualbricks/gui/gui.py.~1~:3109: except:
 virtualbricks/gui/gui.py:436: except:
 virtualbricks/gui/gui.py:1925: except:
 virtualbricks/gui/gui.py:1930: except:
 virtualbricks/gui/gui.py:2909: except:
 virtualbricks/gui/graphics.py:67: except:
 virtualbricks/gui/graphics.py:82: except:
 virtualbricks/tcpserver.py:146: except:

 affects virtualbrick
 assignee <email address hidden>
 importance medium

[Marco Giusti (marco-giusti)]

Here the updated list:

 virtualbricks/bricks.py:206: except:
 virtualbricks/bricks.py:435: except:
 virtualbricks/bricks.py:452: except:
 virtualbricks/console.py:125: except: # XXX don't catch all errors
 virtualbricks/console.py:130: except: # XXX: don't catch all errors
 virtualbricks/wires.py:132: except:
 virtualbricks/wires.py:178: except:
 virtualbricks/events.py:71: except:
 virtualbricks/events.py:171: except:
 virtualbricks/brickconfig.py:85: except:
 virtualbricks/gui/gui.py:420: except:
 virtualbricks/gui/gui.py:1909: except:
 virtualbricks/gui/gui.py:1914: except:
 virtualbricks/gui/gui.py:2893: except:
 virtualbricks/tcpserver.py:146: except:

[Marco Giusti (marco-giusti)]

The fix is lost in the mass of commits.