No cleanup done when file transfer fails with powervm driver

Bug #1173017 reported by ChangBo Guo(gcb)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
ChangBo Guo(gcb)
Grizzly
Fix Released
Low
ChangBo Guo(gcb)

Bug Description

When deploye one instance with powervm driver , it will transfer image file to host , and l leave the file on host when image file transfer fails . Need clean the file in this situation .

see https://github.com/openstack/nova/blob/master/nova/virt/powervm/blockdev.py#L423
            if not output:
                LOG.error(_("Unable to get checksum"))
                raise exception.PowerVMFileTransferFailed()
            if source_cksum != output.split(' ')[0]:
                LOG.error(_("Image checksums do not match"))
                raise exception.PowerVMFileTransferFailed()

We need cleanup the failed file before raising exception.

Tags: powervm
tags: added: grizzly-backport-potential
Changed in nova:
assignee: nobody → ChangBo Guo (guochbo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27534

Changed in nova:
status: New → In Progress
Matt Riedemann (mriedem)
tags: added: powervm
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/27534
Committed: http://github.com/openstack/nova/commit/68cc1cd511298208dde59878bfbef474a3625c9f
Submitter: Jenkins
Branch: master

commit 68cc1cd511298208dde59878bfbef474a3625c9f
Author: Chang Bo Guo <email address hidden>
Date: Thu Apr 25 23:40:12 2013 -0700

    Clean up failed image transfers in instance spawn

    Boot one instance with powervm driver, will transfer the image
    file to host. Need clean up failed image transfers that may occur
    during instance spawn.

    Fixes bug #1173017

    Change-Id: Iff5ecd32e201333567a6a4de1d3796e78ea5dc0c

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/30885

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/30885
Committed: http://github.com/openstack/nova/commit/ee75c2970808e53bb849802d6ade2f9df2d76e0b
Submitter: Jenkins
Branch: stable/grizzly

commit ee75c2970808e53bb849802d6ade2f9df2d76e0b
Author: Chang Bo Guo <email address hidden>
Date: Wed May 29 06:18:39 2013 -0700

    Clean up failed image transfers in instance spawn

    Boot one instance with powervm driver, will transfer the image
    file to host. Need clean up failed image transfers that may occur
    during instance spawn.

    Fixes bug #1173017
    (cherry picked from commit 68cc1cd511298208dde59878bfbef474a3625c9f)

    Change-Id: Id06fa84bee63adc4af96a339526d75540978263f

tags: added: in-stable-grizzly
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Alan Pevec (apevec)
Changed in nova:
importance: Undecided → Low
tags: removed: grizzly-backport-potential in-stable-grizzly
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.