query error when listing available holds

[Galen Charlton]

Requesting a list of available holds for a patron fails with the following error, as exemplified by this srfsh sessions:

2013-04-25 16:21:11 foo open-ils.cstore: [ERR :3559:oils_sql.c:5585:] open-ils.cstore: Error with query [SELECT "ahr".id AS "id" FROM action.hold_request AS "ahr" WHERE "ahr".shelf_time IS NOT NULL AND "ahr".fulfillment_time IS NULL AND "ahr".cancel_time IS NULL AND "ahr".pickup_lib = 'current_shelf_lib' AND "ahr".usr = 1640631 ORDER BY (("ahr".pickup_lib != ( "ahr".current_shelf_lib ))), "ahr".shelf_time, "ahr".frozen, "ahr".request_time;]: 0 ERROR: invalid input syntax for integer: "current_shelf_lib"#012LINE 1: ... "ahr".cancel_time IS NULL AND "ahr".pickup_lib = 'current_s...#012 ^
2013-04-25 16:21:11 foo open-ils.circ: [ERR :1397:CStoreEditor.pm:114:] editor[!|2] request error open-ils.cstore.json_query.atomic : {"from":"ahr","order_by":[{"compare":{"!=":{"+ahr":"current_shelf_lib"}},"class":"ahr","field":"pickup_lib"},{"class":"ahr","field":"shelf_time"},{"class":"ahr","field":"frozen"},{"class":"ahr","field":"request_time"}],"select":{"ahr":["id"]},"where":{"shelf_time":{"!=":null},"fulfillment_time":null,"cancel_time":null,"pickup_lib":{"=":"current_shelf_lib"},"usr":1640631}} : Exception: OpenSRF::DomainObject::oilsMethodException 2013-04-25T16:21:11 OpenILS::Utils::CStoreEditor /usr/local/share/perl/5.10.1/OpenILS/Utils/CStoreEditor.pm:440 <500> Severe query error -- see error log for more details

Evergreen 2.4.0 RC

[Galen Charlton (gmc)]

A patch, written by Bill Erickson and tested by me, is available in the user/gmcharlt/lp1172893_list_avail_holds_signedoff branch of the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1172893_list_avail_holds_signedoff

[Ben Shum (bshum)]

Picked to master and rel_2_4 (for anticipation of 2.4.0)