TPAC - Addition of password messages for patrons

Bug #1172787 reported by Melissa Lefebvre
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

TPAC - Master - Password messages

In jspac a message appeared when the patron went to change their password stating the requirements. This same message is missing in TPAC. The wording from jspac has been added and styled to update_reset.tt2.

Also improved is the message when requesting a forgotten password. Patrons are unaware that a valid email address needs to be in
their record until after they try to send a reset. Wording and styling has been added to password_reset.tt2 to explain the need for an email address.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=620ab03399f310ed77c6a9fd3f72f57fe7149f68

Revision history for this message
Michael Peters (mrpeters) wrote :
tags: removed: pullrequest
Changed in evergreen:
assignee: nobody → Melissa Lefebvre (mlefebvre)
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.5.0-alpha
importance: Undecided → Low
Revision history for this message
Melissa Lefebvre (mlefebvre) wrote :

Revising code based on IRC feedback.

Changed in evergreen:
status: New → In Progress
Revision history for this message
Melissa Lefebvre (mlefebvre) wrote :

Based on IRC feedback the tt2 files have been updated to contain include statements that now point to separate files containing the text. The CSS has also been changed to raise the update_password table and give the new wording some padding.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=b3c9dd34094daf0fc0fb31141a5014222d513298

Changed in evergreen:
status: In Progress → New
tags: added: pullrequest
Revision history for this message
Dan Scott (denials) wrote :

Fabulous, thank you Melissa! I have committed your changes, along with an extra commit that simply includes the "-" operator in the INCLUDE statements to prevent extra whitespace from being added to the generated HTML, as well as adding a linefeed to the end of the new template file (git complains a little bit otherwise).

Your work on this is very much appreciated, thanks for following up on my request!

Changed in evergreen:
status: New → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
assignee: Melissa Lefebvre (mlefebvre) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.