vmware Hyper for nova vnc console url parameters error

Bug #1172177 reported by Yaguang Tang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Yaguang Tang
Grizzly
Fix Released
Critical
Gary Kotton

Bug Description

there is an error in the vmwareapi driver that construct vnc console url,
nova/virt/vmwareapi/vmops.py

1090 param_list = {"id": str(vm_ref)}
1091 base_url = "%s://%s/screen?%s" % (self._session._scheme,
1092 self._session._host_ip,
1093 urllib.urlencode(param_list))
1094 -> request = urllib2.Request(base_url)
1095 base64string = base64.encodestring(
1096 '%s:%s' % (
1097 self._session._host_username,
1098 self._session._host_password)).replace('\n', '')
1099 request.add_header("Authorization", "Basic %s" % base64string)

(Pdb) print vm_ref
(obj){
   value = "3"
   _type = "VirtualMachine"
 }

vm_ref is an object, should use vm_ref.value to get the instance's id.

Tags: vmware
Yaguang Tang (heut2008)
tags: added: vmware
Changed in nova:
assignee: nobody → Yaguang Tang (heut2008)
Yaguang Tang (heut2008)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27405

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/27405
Committed: http://github.com/openstack/nova/commit/2e16432ae0337101c80d8ba6fbdf2e8a9c8d85e7
Submitter: Jenkins
Branch: master

commit 2e16432ae0337101c80d8ba6fbdf2e8a9c8d85e7
Author: Yaguang Tang <email address hidden>
Date: Wed Apr 24 16:54:05 2013 +0800

    Fix VMware Hyper console url parameter error.

    fix bug #1172177

    Change-Id: Iab858741cba61f218c639d76fa80c047196bcc64

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
importance: Undecided → Critical
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Tracy Jones (tjones-i)
tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/40058

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/40058
Committed: http://github.com/openstack/nova/commit/1934dbc8984fe02edb5c410995501cdb87b77647
Submitter: Jenkins
Branch: stable/grizzly

commit 1934dbc8984fe02edb5c410995501cdb87b77647
Author: Yaguang Tang <email address hidden>
Date: Wed Apr 24 16:54:05 2013 +0800

    Fix VMware Hyper console url parameter error.

    fix bug #1172177

    (cherry picked from commit 2e16432ae0337101c80d8ba6fbdf2e8a9c8d85e7)

    Conflicts:

     nova/tests/test_vmwareapi.py
     nova/virt/vmwareapi/vmops.py

    Change-Id: Iab858741cba61f218c639d76fa80c047196bcc64

tags: added: in-stable-grizzly
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential in-stable-grizzly
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.