Allow database module to support DATABASE section instead of DEFAULT

[Gary Kotton]

Quantum uses DATABASE at the moment. This support would help the migration and remove the risk of problems moving forwards

[Mark McLoughlin (markmc)]

If we're to move the DB options into a group, the group's name should be 'database' not 'DATABASE' ... so we need to address https://blueprints.launchpad.net/oslo/+spec/cfg-lowercase-groups first

I'd also have a slight preference for 'db', but if 'database' helps quantum, then that's ok

[Mark McLoughlin (markmc)]

Oh, forgot to mention what you need here is deprecated_group

  sql_opts = [
      cfg.StrOpt('sql_connection',
                            default=...,
                            help=...,
                            secret=True,
                            deprecated_group='DEFAULT'),
  ]

  CONF.register_opts(sql_opts, group='database')

It's pretty horrible that you need to add deprecated_group to all of these, maybe we could do e.g.

  class DbOpt(cfg.StrOpt):
      def __init__(self, name, **kwargs):
          super(DbOpt, self).__init__(name, deprecated_group='DEFAULT', **kwargs)

[Gary Kotton (garyk)]

This is a tricky one.
In Nova it is in the DEFAULT section and in the Quantum it is the DATABASE section. Ideally both should be supported.

[Gary Kotton (garyk)]

Nice suggestion.
Thanks
Gary

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27345

[Davanum Srinivas (DIMS) (dims-v)]

review is here https://review.openstack.org/27345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27345
Committed: http://github.com/openstack/oslo-incubator/commit/4ff33b0390fff7e623be7c2242002e32a47eb855
Submitter: Jenkins
Branch: master

commit 4ff33b0390fff7e623be7c2242002e32a47eb855
Author: Davanum Srinivas <email address hidden>
Date: Tue Apr 23 09:54:22 2013 -0400

    Specify database group instead of DEFAULT

    At the request of Quantum folks, Let us switch from DEFAULT to
    database for the database related options. This will help with
    migration etc.

    DocImpact

    Fixes LP# 1171837

    Change-Id: If602a6a7cc0f2a202632dd14574fea60dce4b589