Outline whitespace issues

[Ari]

Hi again for a third time,

I hope you don't mind me posting all of these bug reports at once. It's just that I've made these observations while using qpdfview extensively over the past month and would like to give you my feedback now that I have the time for it. Please don't feel pressured into implementing any of these requests/fixes right away. Just take your time and address them as you see fit.

I was very glad to see that you've added a page count to the outline pane. This bug report is related to that feature.

### Bug description ###

Sometimes when I open a document I am presented with an overly truncated outline. Widening the pane does not seem to have any effect, the spacing remains off. I have attached a screenshot showcasing the bug.

### Steps to reproduce ###

Unfortunately I have yet to identify under which circumstances the bug appears. It seems to be more or less random. Restarting qpdfview always remedies the issue.

### Additional notes ###

Bug aside, I feel that the spacing between section titles and their respective page numbers is a bit too generous. I think the whitespace could very well be cut down by half or two thirds without impeding the differentiation between section title and page number. At the moment it's very hard to read chapter titles without resizing the side pane. A change in the spacing could help with that.

Thanks again for reading this.

[Ari (ari-lp)]

## Additional information ##

$ apt-cache policy qpdfview
qpdfview:
  Installed: 0.4.2-2~precise1
  Candidate: 0.4.2-2~precise1

[Adam Reichold (adamreichold)]

Hello Ari,

This looks like a problem with the "stretchLastSection" property of Qt's header view. Currently I disable this property once and assumed this would be enough, but maybe I have to set this each time the outline model changes, i.e. when the tab is switched.

I have just committed this in trunk so you can try out if this helps. (revision 1111)

Concerning the identification of the circumstances, maybe it happens when you switch tabs?

Best regards, Adam.

[Ari (ari-lp)]

Hi Adam,

thanks for responding this swiftly. I just downloaded and installed rev. 1116 and unfortunately I have to report that the issue seems to persist. It only appeared once, right when I opened a recently opened document, and disappeared as soon as I opened another file in the same window. I am still at a loss at what's causing it. Switching back and forth between tabs does not appear to trigger it. I've opened about 20 different documents so far in different viewing modes but still no "luck".

I'll report back when I have more insights.

-- Ari

[Adam Reichold (adamreichold)]

Hello again,

Hopefully, I got this now: The problem seems to be refresh or opening, i.e. changing the document displayed in the current tab, i.e. changing its outline model. I committed resetting the header views on model reset in trunk revision 1118. Testing is appreciated.

Regards, Adam.

[Ari (ari-lp)]

Hey Adam,

I have been running rev. 1118 for the past couple of days and the spacing issue has yet to reappear. As far as I can tell the bug is fixed. Great work!

One last question, though; What do you think about my suggestion to reduce the white space between section titles and page numbers? Is this a point we should rather discuss on the mailing list / another bug report?

Thanks again for the quick fix!

Cheers
-- Ari

[Adam Reichold (adamreichold)]

Hello Ari,

Concerning the spacing of the outline elements: It is implemented as two columns where the first (link title) takes as much space as possible and the second (link destination page number) takes as little as possible. I chose to do it this way because it will always use the available space without the need to tune the column sizes. This leads to a very simple implementation and since this is of the program's stated goals and one can control the issue by resizing the view itself, I would rather keep it as is.

Regards, Adam.

[Ari (ari-lp)]

Hi again,

thank you for the explanation. I still wonder, though, why the second column's width isn't smaller if it's set up to take as little space as possible. Does the column width hit a minimum and would this value be hard to change? If so I can understand your decision. Of course I would prefer if the whitespace was trimmed a little but it's nothing world-shattering. As you've said the issue is easily alleviated by resizing the dock.

Cheers
--Ari