Nic Ordering not guaranteed with nova-network API

[Zhi Yan Liu]

The nova-network did not honor nic ordering, so nics were attached in db natural order. I will prepare the patch to sorts the networks honor equested nic ordering when Nova calls the nova-network API.

The related bug and fix about this for quantum api is https://bugs.launchpad.net/nova/+bug/1064524
Regarding quantum has replaced nova-network from havana, this bug and its fix is just for folsom (grizzly if needed).

[Davanum Srinivas (DIMS) (dims-v)]

Zhi Yan Liu, Did you also see this bug? https://bugs.launchpad.net/nova/+bug/1156844

[Zhi Yan Liu (lzy-dev)]

@Dims, they are similar, I have not saw that before I report this. But for now, I don't think they are the same, I will fix it just like quantum fixing did (bug #1064524), that's keep "--nic net-id=<net1> --nic net-id=<net2>" order which be provided from CLI call/API call to provisioned instance vNIC order.
(actually I have already fixed it from our product internal)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27252

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27252
Committed: http://github.com/openstack/nova/commit/90d3371be6c7ec2fc85c92f4744adf4f83003522
Submitter: Jenkins
Branch: master

commit 90d3371be6c7ec2fc85c92f4744adf4f83003522
Author: Zhi Yan Liu <email address hidden>
Date: Mon Apr 22 16:18:54 2013 +0800

    Make nova-network support requested nic ordering

    The nova-network did not honor nic ordering, so nics were attached in db
    natural order. This patch sorts the networks honor requested nic
    ordering when Nova calls the nova-network API.

    Fixes bug: #1170725

    Change-Id: I7dd04ac7bdda95c626cbb0fe35be0aadacb4bd2a
    Signed-off-by: zhiyanl-cn <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/28312

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/28312
Committed: http://github.com/openstack/nova/commit/be0a14a02428f2732c66af2b2272fa44b323787f
Submitter: Jenkins
Branch: stable/grizzly

commit be0a14a02428f2732c66af2b2272fa44b323787f
Author: Zhi Yan Liu <email address hidden>
Date: Mon Apr 22 16:18:54 2013 +0800

    Make nova-network support requested nic ordering

    The nova-network did not honor nic ordering, so nics were attached in db
    natural order. This patch sorts the networks honor requested nic
    ordering when Nova calls the nova-network API.

    Fixes bug: #1170725

    Change-Id: I7dd04ac7bdda95c626cbb0fe35be0aadacb4bd2a
    Signed-off-by: zhiyanl-cn <email address hidden>
    (cherry picked from commit 90d3371be6c7ec2fc85c92f4744adf4f83003522)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/31923