wayland - fullscreen does not resize benchmark

[Joe Konno]

While `glmark2-es2-wayland -b buffer:duration=2 --fullscreen` does indeed create a fullscreen surface, there is insufficient logic to resize the benchmark to the dimensions of that fullscreen surface. The benchmark geometry get set to 640x480. This is obvious when running a Weston instance at high resolution (e.g. 1920x1080).

[Joe Konno (jbkonno)]

For displays with multiple possible resolutions-- like my monitor-- glmark2's current logic is generating events for, and handling, every modeline supported by the display and setting it. So, in my case, my display lists modelines from 1920x1080 at various frequencies down to, say, 640x480. N output_mode events are generated, and the benchmark's surface is resized n times, with the final modeline entry being "the" dimensions for the duration of program execution-- in my case, 640x480. After all those events are handled, I have a fullscreen surface (1920x1080) drawing a 640x480 benchmark.

Locally, I set a bit after the first output_mode event is handled, which properly scales the benchmark, and then early-return every event thereafter. In other words, "the first event is right." This gives me the desired result. This is clearly a hack and not a proper fix. Investigating the "right" way to do this.

[Joe Konno (jbkonno)]

By checking the event's flags, one can determine which events represents the shell's "current" mode. Down the road we may discover a more eloquent way to bring up the window and surface, but this patch appears to enable fullscreen benchmarking on Wayland.

[Joe Konno (jbkonno)]

Let me know if there's anything preventing this patch from being merged. Cheers.

[Jesse Barker (jesse-barker)]

Hi Joe,

I can't test your patch directly at the moment, but if it works for you, I should be able to get it merged over the weekend.

cheers,
Jesse

[Joe Konno (jbkonno)]

Rafal, could I trouble you for a review? If not, it's cool, but figured I'd ask all the same. ^_^

[Rafal Mielniczuk (kruk87)]

Hey Joe, I think this patch is good, thanks

regards,
Rafał

[Jesse Barker (jesse-barker)]

I've applied the patch to trunk.

cheers,
Jesse