Percona XtraBackup moved to https://jira.percona.com/projects/PXB

require_partitioning in test/inc/ib_part.sh does not work with 5.6

Bug #1170340 reported by Alexey Kopytov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup moved to https://jira.percona.com/projects/PXB
Fix Released
Medium
Alexey Kopytov
Percona XtraBackup moved to https://jira.percona.com/projects/PXB 2.1.0-rc1 "Chaubunagungmamgnamaugg"
2.0
Fix Released
Medium
Alexey Kopytov
Percona XtraBackup moved to https://jira.percona.com/projects/PXB 2.0.7
2.1
Fix Released
Medium
Alexey Kopytov
Percona XtraBackup moved to https://jira.percona.com/projects/PXB 2.1.0-rc1 "Chaubunagungmamgnamaugg"

Bug Description

All partitioning tests are skipped when running against a 5.6 server, because require_partitioning fails. It uses the have_partitioning variable, which is obsolete in 5.6.

Using SHOW ENGINES as suggested in the manual does not work though (http://bugs.mysql.com/bug.php?id=68996). We could be using I_S.PLUGINS as a workaround, but that table is unavailable in 5.0 (and 5.0 is the only reason why that check exists). I think we should probably just replace the code in require_partitioning with a simple version check.

See original description

Related branches

lp:~akopytov/percona-xtrabackup/bug1169169-2.0
Laurynas Biveinis (community): Approve
Diff: 1246 lines (+477/-136)
20 files modified
innobackupex (+32/-3)
patches/innodb56.patch (+189/-38)
src/xtrabackup.cc (+52/-7)
test/inc/common.sh (+47/-27)
test/inc/ib_part.sh (+5/-5)
test/t/bug1062684.sh (+11/-4)
test/t/bug483827.sh (+1/-4)
test/t/bug606981.sh (+9/-5)
test/t/bug740489.sh (+22/-14)
test/t/bug759225.sh (+6/-4)
test/t/bug870119.sh (+6/-3)
test/t/bug891496.sh (+6/-8)
test/t/bug976945.sh (+4/-2)
test/t/bug977101.sh (+3/-4)
test/t/ib_doublewrite.sh (+6/-3)
test/t/ib_slave_info.sh (+2/-2)
test/t/undo_tablespaces.sh (+75/-0)
test/t/xb_basic.sh (+0/-1)
test/t/xb_version.sh (+0/-1)
test/testrun.sh (+1/-1)
lp:~akopytov/percona-xtrabackup/bug1169169-2.1
Laurynas Biveinis (community): Approve
Diff: 86 lines (+55/-6) (has conflicts)
2 files modified
patches/innodb56.patch (+50/-1)
test/inc/ib_part.sh (+5/-5)
Alexey Kopytov (akopytov)
description: updated
Revision history for this message
Jaime Crespo (jynus) wrote :

What about:
$MYSQL $MYSQL_ARGS -BAN -e "SHOW PLUGINS" 2> /dev/null | grep -q -r "^partition\b"
?

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Yes, SHOW PLUGINS / I_S.PLUGINS would work too, simply because the statement would fail on 5.0. It is better than a version check, because it would also fail on 5.1+ servers built without partitioning.

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-626

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.