cannot reboot instances when in rescue mode

[Matthew Sherborne]

When you attempt to reboot an instance that is in rescue mode, all it does is reset the vm_state from RESCUED to ACTIVE.

in xenapi, it attempts to reboot the non-rescued instance, but that has a boot lock on it.

----

It should be possible to reboot an instance that is in rescue mode, without setting it to ACTIVE.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27100

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27107

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27100
Committed: http://github.com/openstack/nova/commit/39ffe806cdfe97721fee5e48c8591c4c3b52766b
Submitter: Jenkins
Branch: master

commit 39ffe806cdfe97721fee5e48c8591c4c3b52766b
Author: Matthew Sherborne <email address hidden>
Date: Thu Apr 18 14:37:52 2013 +1000

    Stop vm_state reset on reboot of rescued vm

    When a VM is in rescue mode, giving it a reboot will reset its state in
    the DB back to ACTIVE.

    This patch stops that happening.

    Work towards bug: 1170237
    Change-Id: Ie442bcc85ed7ad5d897b88ffd0dbcf6eeee7b990

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27105
Committed: http://github.com/openstack/nova/commit/4c887edc8840327ce707d2015fa50ac625bb17db
Submitter: Jenkins
Branch: master

commit 4c887edc8840327ce707d2015fa50ac625bb17db
Author: Matthew Sherborne <email address hidden>
Date: Thu Apr 18 15:34:31 2013 +1000

    Allows xenapi 'lookup' to look for rescue mode VMs

    When you lookup a VM by name, you can specify if you want it to check if
    it has a rescue mode instance running.

    If it finds the rescue mode instance, it'll return that one instead
    of the original name.

    This is useful for operations that should work on the rescue mode vm if
    it's there, or the normal one, if it's not.

    Work towards bug: 1170237
    Change-Id: I41b31e59631b78a62faadb9970b6b824929e7061

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27107
Committed: http://github.com/openstack/nova/commit/b4dc932c2a10c3d9c678cf759f94237504661348
Submitter: Jenkins
Branch: master

commit b4dc932c2a10c3d9c678cf759f94237504661348
Author: Matthew Sherborne <email address hidden>
Date: Thu Apr 18 17:51:52 2013 +1000

    Can now reboot rescued instances in xenapi

    This patch makes it possible to reboot an instance that is in rescue mode.

    It causes the reboot action to search first for rescue mode VM (the
    normal VMs name plus '-rescue') .. if it can't find it, it does a reboot
    of the normal VM. If it finds the rescue one first, it'll reboot the
    rescue instance.

    If there is more than one VM named 'myvm-rescue', it'll raise an
    exception just like it did if there were more than one VM named 'myvm'.

    Helps with bug: 1170237

    Change-Id: I1858d86bf93546618eeaaec92d856f5236f3f090

[John Garbutt (johngarbutt)]

It seems this is now fixed.

[John Garbutt (johngarbutt)]

Ignore me, I didn't spot the status was correct.