The ubuntu patch on 1.3.0-1/src/pcscd_ccid.rules is not correct

[Ludovic Rousseau]

Binary package hint: libccid

Hello,

I am the Debian and upstream maintainer of ccid.

In http://patches.ubuntu.com/c/ccid/ccid_1.3.0-1ubuntu1.patch I see:

diff -pruN 1.3.0-1/src/pcscd_ccid.rules 1.3.0-1ubuntu1/src/pcscd_ccid.rules
--- 1.3.0-1/src/pcscd_ccid.rules 2007-05-09 20:06:04.000000000 +0100
+++ 1.3.0-1ubuntu1/src/pcscd_ccid.rules 2007-05-16 13:11:34.000000000 +0100
@@ -22,7 +22,9 @@ BUS=="usb", ATTRS{idVendor}=="09be", ATT
 # SCR331-DI-NTTCom.txt
 BUS=="usb", ATTRS{idVendor}=="04e6", ATTRS{idProduct}=="5120", RUN+="/usr/sbin/pcscd --hotplug"
 # SCR331-DI.txt
-BUS=="usb", ATTRS{idVendor}=="04e6", ATTRS{idProduct}=="5111", RUN+="/usr/sbin/pcscd --hotplug"
+BUS=="usb", SYSFS{idVendor}=="04e6", SYSFS{idProduct}=="5111", ACTION=="add", RUN+="/usr/sbin/pcscd --hotplug"
+# SCR335
+BUS=="usb", SYSFS{idVendor}=="04e6", SYSFS{idProduct}=="5115", ACTION=="add", RUN+="/usr/sbin/pcscd --hotplug"
 # SDI010.txt
 BUS=="usb", ATTRS{idVendor}=="04e6", ATTRS{idProduct}=="5121", RUN+="/usr/sbin/pcscd --hotplug"
 # SPR532.txt

This patch is not correct:
- no need to add ACTION=="add", since the file has a ACTION!="add", GOTO="pcscd_ccid_rules_end"
- the SCR335 has the CCID class byte set correctly so it should trigger the rule:
# generic CCID device
BUS=="usb", ATTRS{bInterfaceClass}=="0b", RUN+="/usr/sbin/pcscd --hotplug"

[Ludovic Rousseau (ludovic-rousseau-gmail)]

This bug is still present in Ubuntu 7.10

[Marco Rodrigues (gothicx)]

Fixed in version 1.3.1-1