backup-delete removes backup from database

Bug #1169943 reported by Michael Kerrin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Michael Kerrin
Grizzly
Fix Released
High
John Griffith

Bug Description

After creating a backup, and removing the backup I looked in the backup table in the database and there are no rows.

We shouldn't delete the row but instead set the deleted & deleted_at fields in the database

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27072

Changed in cinder:
assignee: nobody → Michael Kerrin (michael-kerrin-w)
status: New → In Progress
tags: added: grizzly-backport-potential
Changed in cinder:
importance: Undecided → High
milestone: none → havana-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/27072
Committed: http://github.com/openstack/cinder/commit/a4ba17b668bd893d50fd4f3a5453da89966a77e3
Submitter: Jenkins
Branch: master

commit a4ba17b668bd893d50fd4f3a5453da89966a77e3
Author: Michael Kerrin <email address hidden>
Date: Wed Apr 17 15:36:28 2013 +0000

    Deleting a backup removed the backup record from database

    Instead we should be marking the backup as deleted so that we have an audit
    of all the backups. Backups are now marked deleted in the way that volumes
    are.

    Fixes bug: 1169943
    Fixes bug: 1169857

    Change-Id: I52c603be138c0f1d6d411d167977041255ac9053

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/28205

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/grizzly)

Reviewed: https://review.openstack.org/28205
Committed: http://github.com/openstack/cinder/commit/2e3c1cd77b3d523c48ff4a086cccf68fd11c4c19
Submitter: Jenkins
Branch: stable/grizzly

commit 2e3c1cd77b3d523c48ff4a086cccf68fd11c4c19
Author: Michael Kerrin <email address hidden>
Date: Wed Apr 17 15:36:28 2013 +0000

    Dont delete backup record from database

    Instead we should be marking the backup as deleted so that we have an audit
    of all the backups. Backups are now marked deleted in the way that volumes
    are.

    Fixes bug: 1169943
    Fixes bug: 1169857

    Change-Id: I52c603be138c0f1d6d411d167977041255ac9053
    (cherry picked from commit a4ba17b668bd893d50fd4f3a5453da89966a77e3)

Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.