Add "about" search results page to reflect that search results count is an estimate

Bug #1168800 reported by Kathy Lussier
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

As was discussed in IRC a couple of weeks ago, the result count is an estimate when retrieving a large result set - http://evergreen-ils.org/irc_logs/evergreen/2013-03/%23evergreen.28-Thu-2013.log#line149. I added the work "about" to the results page so that it now reads "Results 1-10 of about x".

While adding the word "about", I also did the following:

* I moved the <strong> HTML tags out of the inline code and created a CSS class to handle the formatting.

* As recommended by Pasi Kallinen, I moved HTML tags out of the translatable strings

* I fixed a typo where a "result_numbers" class had been created in style.css.tt2, but the class was referred to as "result_number" in paginate.tt2. In fixing the typo, I found that the resulting text size for the result count was too small. Two other people at the hackfest agreed with me, so I tweaked the style.

Branch is available in working at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/approximate_results

Tags: pullrequest
Ben Shum (bshum)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Mike Rylander (mrylander) wrote :

Picked into master ... until/unless we get full, pure-SQL counts, we should reduce confusion. Thanks, Kathy!

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.4.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.