OpenStack Compute (nova)

qemu_image_info should not return empty QemuImgInfo objects

Bug #1168318 reported by Hans Lindgren
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Davanum Srinivas (DIMS)
OpenStack Compute (nova) 2014.2 "juno"

Bug Description

In nova/virt/images.py, if qemu-img command fails or the image is missing, instead of returning en empty QemuImgInfo it should probably throw some exception to inform the caller of the situation instead of hiding the problem like it does today.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/26873

Changed in nova:
assignee: nobody → Chuck Short (zulcss)
status: New → In Progress
Revision history for this message
Joe Gordon (jogo) wrote :

patch was abandoned

Changed in nova:
status: In Progress → Incomplete
Revision history for this message
Sean Dague (sdague) wrote :

This is a valid bug, and actually something we should probably prioritize as it makes debugging pretty hard if it goes wrong.

Changed in nova:
importance: Undecided → High
status: Incomplete → Confirmed
assignee: Chuck Short (zulcss) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/119456

Changed in nova:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/119456
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2ed3e28442e7dd8ded485cdf96a2053386441051
Submitter: Jenkins
Branch: master

commit 2ed3e28442e7dd8ded485cdf96a2053386441051
Author: Davanum Srinivas <email address hidden>
Date: Fri Sep 5 15:51:53 2014 -0400

    Raise an exception if qemu-img fails

    Raise an exception if the qemu image doesn't
    exist or qemu-img fails.

    Co-Authored-By: Chuck Short <email address hidden>
    Closes-Bug: #1168318
    Change-Id: I6b4123590e7d2934de0bc6add900d708d5986039

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.