Corporate names not showing up in TPAC search results

[Yamil]

Corporate names, bib tag 110, are not showing up in TPAC search results, only bib tag 100 authors are showing up in search results since at least the first release of TPAC.

On EG 2.2.5 this bug can be fixed by updating a line in...
/Open-ILS/src/templates/opac/parts/misc_util.tt2

FOR sub IN xml.findnodes('//*[@tag="100"]/*[@code="a"]');

and changing it to...

FOR sub IN xml.findnodes('//*[@tag="100" or @tag="110"]/*[@code="a"]');

Regretfully the code for misc_util.tt2 in EG master (as of April 10th, 2013) and EG 2.4 alpha1 is different enough that I do not know yet how to fix it. It seems the change happened in RDA related commit a1f619bd3748c52ea177e52898bdf7b27826e007 "TPAC: Alternate graphic fields (880) display"

[Dan Wells (dbw2)]

Simple attempt at fix for master here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1168186

working/user/dbwells/lp1168186

I have not branchified Yamil's fix for 2.3 yet, but pullrequest and testing still welcome.

[Ben Shum (bshum)]

Following along Dan's fix, I added another commit for tag 111. Yamil also noticed that subfield 4 was being displayed as part of the author links and should not be.

Branch: working/user/bshum/lp1168186

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1168186

[Yamil (ysuarez)]

I like what Dan Wells and Ben Shum have done, I think with Ben's addition that we could consider closing the ticket for version 2.4. I (or someone else) can still write some new code to back port to 2.3 and 2.2, etc.

I also found that in search results for the author data, in 2.2 and 2.3, are only showing subfield "a" data. Thankfully 2.4 does not have this issue, because most 1xx fields like d,c,b should display if present. Not sure if this issue of the extra 1xx subfields should be a separate bug or not.

[Mark Cooper (markchristophercooper)]

Works for me as described above on 2.4.0 --

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=e3ad828f9e7d3671ca5d398fa1e4a2fb0fb90008

[Ben Shum (bshum)]

Thanks for testing Dan. Picked to master and rel_2_4. Will work on the rel_2_3 and rel_2_2 backports before the next month's maintenance releases.

[Ben Shum (bshum)]

Err, sorry for testing Mark! And Yamil, and Dan! :D

[Ben Shum (bshum)]

Marking as "won't fix" for 2.2 because we are outside the 2.2 support timeframe for non-security bug fixes.