AutoDJ #1 is missing

[Daniel Schürmann]

If you select:
At to AutoDJ (Top) with no track in Auto DJ, tracks are queued at 2.
That causes a lot of issues when shuffling an manual interact with the Auto DJ

It would be very nice, if we could fix this for 1.11.0!

[Daniel Schürmann (daschuer)]

I think we have reinvented: Bug #982652

[Steven Boswell (ulatekh)]

I'm pretty sure this is an easy fix.
In src/widget/wtracktableview.cpp, near line 1022 (in the 1.11 branch), it needs to check if the auto-DJ queue has some tracks in it already before inserting a new track into position 2, otherwise, just append the track to the list.

[Daniel Schürmann (daschuer)]

Thank you for the hint!
I think the bug is in mixxx/src/library/dao/playlistdao.cpp:

 // Get the position of the highest track in the playlist.
 int position = 0;
 if (query.next()) {
     position = query.value(query.record().indexOf("position")).toInt();
 }
 return position;

I will run Mixxx inside gdb and see what happens.

[Steven Boswell (ulatekh)]

For adding a playlist to the auto-DJ queue, yes, src/library/dao/playlistdao.cpp, near line 518, is the source of the bug.
For adding a single track to the auto-DJ queue, it's in src/widget/wtracktableview.cpp, near line 1022.

My line numbers are relative to the 1.11 branch.

[Daniel Schürmann (daschuer)]

Thank you Steven. Yes, a possible fix could start there.
But I prefer a more general fix in int PlaylistDAO::insertTracksIntoPlaylist()

The original patch from Bug #982652 fixes the problem for PlaylistDAO::insertTrackIntoPlaylist().
At the same time 2837.3.51 introduces PlaylistDAO::insertTracksIntoPlaylist() without the patch.

I have just committed a fix to lp:mixxx/1.11 r3812.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6985