Update to TPAC shelf browser CSS styles (record author)

[Yamil]

Patrons were getting confused when looking at the shelf browser results, because it was hard to tell which was an item's title versus author because both were displayed as plain text, instead of having the title "bolded" and the author emphasized/stylized. Now the stylings for title and author match what is used in TPAC search results from...

/Open-ILS/src/templates/opac/parts/result/table.tt2

Update to TPAC shelf browser (cnbrowse.tt2[1])CSS styles to match the CSS styles of TPAC search results for item result titles and authors. Added a "emphasis" tag and added a "bold" class.

[1] /Open-ILS/src/templates/opac/parts/record/cnbrowse.tt2

[Dan Scott (denials)]

Hi Yamil: Thanks for the branch!

While it does make the rendering consistent, I took a different approach to addressing this problem. Rather than following the existing approach in the templates of using <em> tags and CSS classes like "bold" that effectively hardcode presentation-based style decisions into the templates (and thus rendering the value of CSS null), I defined two new CSS classes: "record_author" and "record_title", and applied those classes to both the search results table and the browse results table.

With this branch, a site could decide to remove "font-style: emphasis;" from the style.css definition for record_author, and it will be reflected in both search results pages.

Would you be interested in signing-off on this branch?

See user/dbs/tpac_author_name_style in the working repository: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/tpac_author_name_style

[Yamil (ysuarez)]

Dan,

Thanks for taking my simple code and tweaked it to improve the separation of content versus style in that corner of TPAC.

I just tried my first sign-off by adapting these steps "Adding a Sign-off to a new feature in a Collab branch"...

http://evergreen-ils.org/dokuwiki/doku.php?id=dev:git&s[]=git#adding_a_sign-off_to_a_new_feature_in_a_collab_branch

Here is my new branch with my sign-off...

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ysuarez/tpac_author_name_style

My apologies if I did something wrong.

Yamil

[Ben Shum (bshum)]

Looks good to me too. Pushed to master, thanks Yamil and Dan!