xenapi: _connect_volume exception handler not eventlet safe

Bug #1167515 reported by Rick Harris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Rick Harris

Bug Description

Exception handler calls forget_sr which blocks and clears the exception-context before trying to re-raise the exception.

Since the exception context has been cleared, we get an error on reraise that looks like:

exceptions must be old-style classes or derived from BaseException, not NoneType

Tags: xenserver
Changed in nova:
assignee: nobody → Rick Harris (rconradharris)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/26657

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/26657
Committed: http://github.com/openstack/nova/commit/a2a9f16889b5b74de0daccab3e5011ad0f4d1e94
Submitter: Jenkins
Branch: master

commit a2a9f16889b5b74de0daccab3e5011ad0f4d1e94
Author: Rick Harris <email address hidden>
Date: Wed Apr 10 19:04:30 2013 +0000

    xenapi: Make _connect_volume exc handler eventlet safe

    `forget_sr` blocks and so clears the exception state causing the
    subsequent raise to try to raise `None`, which fails.

    Fixes bug 1167515

    Change-Id: I18562c7389b152a6490d352c5a8d36934288f47d

Changed in nova:
status: In Progress → Fix Committed
tags: added: xenserver
Changed in nova:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.