warnings during build

[Matěj Cepl]

g++ -o build/exiv2wrapper.os -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC -I/usr/include/python2.7 src/exiv2wrapper.cpp
In file included from /usr/include/exiv2/metadatum.hpp:39:0,
                 from /usr/include/exiv2/exif.hpp:34,
                 from /usr/include/exiv2/image.hpp:41,
                 from src/exiv2wrapper.hpp:31,
                 from src/exiv2wrapper.cpp:26:
/usr/include/exiv2/value.hpp:984:25: note: attribute for 'struct Exiv2::DateValue::Date' must follow the 'struct' keyword
         EXIV2API struct Date
                         ^
src/exiv2wrapper.cpp: In function 'void exiv2wrapper::registerXmpNs(const string&, const string&)':
src/exiv2wrapper.cpp:1365:28: warning: unused variable 'ns' [-Wunused-variable]
         const std::string& ns = Exiv2::XmpProperties::ns(prefix);
                            ^
src/exiv2wrapper.cpp: In function 'void exiv2wrapper::unregisterXmpNs(const string&)':
src/exiv2wrapper.cpp:1385:37: warning: unused variable 'info' [-Wunused-variable]
             const Exiv2::XmpNsInfo* info = Exiv2::XmpProperties::nsInfo(prefix);
                                     ^
g++ -o build/exiv2wrapper_python.os -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC -I/usr/include/python2.7 src/exiv2wrapper_python.cpp
In file included from /usr/include/exiv2/metadatum.hpp:39:0,
                 from /usr/include/exiv2/exif.hpp:34,
                 from /usr/include/exiv2/image.hpp:41,
                 from src/exiv2wrapper.hpp:31,
                 from src/exiv2wrapper_python.cpp:26:
/usr/include/exiv2/value.hpp:984:25: note: attribute for 'struct Exiv2::DateValue::Date' must follow the 'struct' keyword
         EXIV2API struct Date
                         ^
trying to build pyexiv2-0.3.2 with libexif-0.6.21

[Olivier Tilloy (osomon)]

Thanks for the report Matej. Can you specify the version of libexiv2-dev you have?

pyexiv2 doesn’t use or link against libexif.

[Matěj Cepl (mcepl)]

sorry, my mistake, it's exiv2-devel-0.23-4.el7.x86_64 of course.

[Loïc Minier (lool)]

Seems awfully like
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=713032

I'm getting this error when building galery-app too.

[Florian W. (florian-will)]

Exiv2 compiler warning appears to be this bug that was fixed in 0.24 release (dec 2013):
http://dev.exiv2.org/issues/859

[Niels Kristian Bech Jensen (nkbjensen)]

This warning is easy to fix:

In file included from /usr/include/exiv2/metadatum.hpp:39:0,
                  from /usr/include/exiv2/exif.hpp:34,
                  from /usr/include/exiv2/image.hpp:41,
                  from src/exiv2wrapper.hpp:31,
                  from src/exiv2wrapper_python.cpp:26:
 /usr/include/exiv2/value.hpp:984:25: note: attribute for 'struct Exiv2::DateValue::Date' must follow the 'struct' keyword
          EXIV2API struct Date
                          ^

Change line 984 in /usr/include/exiv2/value.hpp to:

struct EXIV2API Date

Regards,
Niels Kristian