Ctrl+destroying a flag with a building does not destroy the whole road

Bug #1167242 reported by wl-zocker
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned

Bug Description

Steps to reproduce:

- Start a new game.
- Build a road. Make sure it consists of at least three flags (it needn't be connected to the headquarters).
- (If you destroy one flag while pressing Ctrl, the whole road will be removed.) (1)
- Build a building at one end of the road.
- (If you destroy the building while pressing Ctrl, the confirmation will be skipped.) (2)
- Destroy the flag in front of the building while pressing Ctrl.

Expected result:
The building is destroyed without confirmation (2) and the road is destroyed up to the next junction (1).

Actual result:
(2) happens, but only one flag (the one you clicked on) is destroyed.

I think that is a bug because if I destroy a flag with Ctrl, I want the whole road to be removed. If I only want to destroy a building, I normally do this via the building menu. Furthermore, a road into empty land makes no sense.

Tested with r6549, but it migth appear since both (1) and (2) can be done with control.

Related branches

Revision history for this message
Nicolai Hähnle (nha) wrote :

The behaviour is a bit weird: If you click normally on the "destroy flag" button and then Ctrl-click in the confirmation window, the entire road is destroyed. I agree that Ctrl-clicking the "destroy flag" button should destroy both the building and the entire road without confirmation.

Changed in widelands:
status: New → Confirmed
importance: Undecided → Low
tags: added: lowhangingfruit
SirVer (sirver)
Changed in widelands:
status: Confirmed → Fix Committed
milestone: none → build19-rc1
Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Fix Committed → Incomplete
Revision history for this message
wl-zocker (wl-zocker) wrote :

Why was this set to incomplete? The fix still works in r7056.

Revision history for this message
SirVer (sirver) wrote :

But in the script that sweeps bugs. Should be fixed for the future.

Changed in widelands:
status: Incomplete → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.