info/codecs_attachment job has incorrect driver requirement

[Daniel Manrique]

name: codecs_attachment
plugin: attachment
requires: device.driver == 'HDA Intel'
command: cat /proc/asound/card*/codec#*
_description: Attaches a report of installed codecs for Intel HDA

I noticed that plainbox was showing this, indicating that the requirement line may be mis-specified:

- codecs_attachment: not-supported
  * resource expression "device.driver == 'HDA Intel'" evaluates to false

Sure enough, I went to a checkbox-submission on c3, which has the codecs_attachment (so hey, it's attaching something), but on opening the attachment I see the damning evidence:

Job requirement not met: 'device.driver == 'HDA Intel''

So this job's requirement is completely borked.

Looking at udev_resource output, there is NO device with driver 'HDA Intel'. Audio devices look like this:

path: /devices/pci0000:00/0000:00:1b.0
bus: pci
category: AUDIO
driver: snd_hda_intel
product_id: 15190
vendor_id: 32902
subproduct_id: 49291
subvendor_id: 5197

There are a few with product: HDA Intel <something> like:

path: /devices/pci0000:00/0000:00:1b.0/sound/card0/input10
bus: input
category: OTHER
product: HDA Intel Headphone

path: /devices/pci0000:00/0000:00:1b.0/sound/card0/input8
bus: input
category: OTHER
product: HDA Intel HDMI/DP,pcm=3

So perhaps the requires line should instead be:

requires: device.driver == 'snd_hda_intel'

if I change that and then run plainbox run -i codecs_attachment -f xml, the job passes and the attachment contains the correct information.