GThread API >= 2.32 compatibility

Bug #1164959 reported by Tomasz Gebarowski
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
El Jardin
Fix Committed
High
Tomasz Gebarowski

Bug Description

Jardin is not compatible with GThread API >= 2.32

Changed in eljardin:
importance: Undecided → High
assignee: nobody → Tomasz Gebarowski (tgebarowski)
Revision history for this message
Tomasz Gebarowski (tgebarowski) wrote :
Changed in eljardin:
status: New → Fix Committed
assignee: Tomasz Gebarowski (tgebarowski) → Gerald Young (gerald-young)
Revision history for this message
Tomasz Gebarowski (tgebarowski) wrote :

Gerald can you review?

Revision history for this message
Aleksander Morgado (aleksander-m) wrote :

Instead of the configure checks, better just use:

#if GLIB_CHECK_VERSION (2,32,0)
      something
#endif

And, instead of:
   #include "../src/common/jardin_macros.h"
Better maybe add the common dir to CPPFLAGS?

Revision history for this message
Tomasz Gebarowski (tgebarowski) wrote :

Thanks for suggestions!

Revision history for this message
Gerald Young (gerald-young) wrote :

I'm getting macro redefinition errors for jardin_mutex_init and jardin_mutex_clear. Dropping the second definition gets rid of the errors (Jardin uses static mutexes only).

Also it seems that src/server/jardin_server_stats.c does not include config.h prior to including jardin_macros.h so that leads to some errors.

I'm building with glib-2.0 and gobject-2.0 version 2.28.6 (so using old API).

Changed in eljardin:
assignee: Gerald Young (gerald-young) → Tomasz Gebarowski (tgebarowski)
Revision history for this message
Tomasz Gebarowski (tgebarowski) wrote :

Re-fixed in: http://bazaar.launchpad.net/~tgebarowski/eljardin/glib-2.32-support/revision/26

Checked compilation using both old and new version of GThread API.

Revision history for this message
Gerald Young (gerald-young) wrote :

Fixes are good.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.