Small fixes for alt sub editor integration
Bug #1164012 reported by
Dan Wells
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
This branch applies some polish to the alt sub editor integration:
- Prevent spinner from displaying continuously when adding a subscription
- Hide the editor when changing subscriptions to limit confusion about what is loaded
- Dynamically add a node to the tree view when adding a subscription
- Make sure the 'View/Edit' tab gets populated when backing out of the stream or item view
- Apply some default link styles
Single squashed commit here:
http://
working/
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This really rounds off some rough edges, some of which were longstanding in Alternate Serials Control view anyway.
Thanks Dan! I'll merge this now.
Look ma, testing!
14:50 <senator> that need to style links,
make sense of it.
interfaces using tt2/dojo, wrapping the page in a <browser> xul
element and providing the go back/ go forward/ reload /print
page buttons?
along with it
probably don't want all that go back/go forward given the way
this integreation works
receive from scv. hah!
14:50 <senator> your solution for now is just fine
14:51 <senator> i think i have a note about that for future reference though
14:51 <dbwells> That would be great, I tried a whole bunch of things and didn't
15:08 <senator> ok, sorry, this won't really be that useful now that i look at
it aesthetically
15:08 <senator> but when you use that shim that you see in the staff client for
15:09 <senator> something about that thing brings more reasonable stylesheets
15:09 <senator> if you have a bare iframe like you're using here, you tend to
get that links-have-no-style problem
15:09 <senator> but anyway, your solution is actually fine the way it is. you
15:10 <senator> also, this
15:10 <senator> Make sure the 'View/Edit' tab gets populated when backing out
of
15:10 <senator> the stream or item view
15:10 <senator> actually seems to fix a bug in just plain old ascv as well
15:11 <senator> so you++
15:19 <senator> and before this it hadn't occured to me to try to jump to batch
15:19 <senator> this all looks great