Small fixes for alt sub editor integration

Bug #1164012 reported by Dan Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

This branch applies some polish to the alt sub editor integration:

 - Prevent spinner from displaying continuously when adding a subscription
 - Hide the editor when changing subscriptions to limit confusion about what is loaded
 - Dynamically add a node to the tree view when adding a subscription
 - Make sure the 'View/Edit' tab gets populated when backing out of the stream or item view
 - Apply some default link styles

Single squashed commit here:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/integrated_alt_sub_editor_cleanup

working/user/dbwells/integrated_alt_sub_editor_cleanup

Tags: pullrequest
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

This really rounds off some rough edges, some of which were longstanding in Alternate Serials Control view anyway.

Thanks Dan! I'll merge this now.

Look ma, testing!

14:50 <senator> that need to style links,
14:50 <senator> your solution for now is just fine
14:51 <senator> i think i have a note about that for future reference though
14:51 <dbwells> That would be great, I tried a whole bunch of things and didn't
                make sense of it.
15:08 <senator> ok, sorry, this won't really be that useful now that i look at
                it aesthetically
15:08 <senator> but when you use that shim that you see in the staff client for
                interfaces using tt2/dojo, wrapping the page in a <browser> xul
                element and providing the go back/ go forward/ reload /print
                page buttons?
15:09 <senator> something about that thing brings more reasonable stylesheets
                along with it
15:09 <senator> if you have a bare iframe like you're using here, you tend to
                get that links-have-no-style problem
15:09 <senator> but anyway, your solution is actually fine the way it is. you
                probably don't want all that go back/go forward given the way
                this integreation works
15:10 <senator> also, this
15:10 <senator> Make sure the 'View/Edit' tab gets populated when backing out
                of
15:10 <senator> the stream or item view
15:10 <senator> actually seems to fix a bug in just plain old ascv as well
15:11 <senator> so you++
15:19 <senator> and before this it hadn't occured to me to try to jump to batch
                receive from scv. hah!
15:19 <senator> this all looks great

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Merged to master

Changed in evergreen:
status: New → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.