Invalid reference to self in functional test test_scrubber.py

Bug #1163617 reported by John Bresnahan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
John Bresnahan

Bug Description

The functional test test_scrubber.py has a function wait_for_scrub() that is not a member of an BaseTest object, yet it makes a call to self.fail() when a problem occurs. self is an invalid reference.

Changed in glance:
milestone: none → havana-1
assignee: nobody → John Bresnahan (jbresnah)
Changed in glance:
status: New → Triaged
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25966

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/25966
Committed: http://github.com/openstack/glance/commit/07eda706f43c907b1d212a48c6b9514d83bbcdc1
Submitter: Jenkins
Branch: master

commit 07eda706f43c907b1d212a48c6b9514d83bbcdc1
Author: John Bresnahan <email address hidden>
Date: Tue Apr 2 13:57:53 2013 -1000

    Invalid reference to self in functional test test_scrubber.py

    In the test_scrubber.py the function wait_for_scrub() makes a
    reference to self even tho it is not a member of any class and
    has no such reference in its scope. This patch makes that
    function a method in the test class so that it can assert the
    failure which it intends.

    fixes bug: 1163617

    Change-Id: I453c8097363dc2f7577fd807ffe8cbc613078258

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.