Workers exiting warehouse do not follow flag

[_aD]

When a warehouse is destroyed or dismantled, workers do not exit at the flag and join the road network; they act "lost" until they find a flag. They should exit to the flag and join the road network.

[SirVer (sirver)]

I think when a warehouse is destroyed by an enemy, this behavior is wanted. But I agree that it should not happen when the player burns it down herself.

One way would be to check for a baseflag and launch the workers when there is one - if there is no baseflag, make the workers all lost. This still looks strange, when the warehouse is destroyed by ripping his base flag, but that cant't be helped.

[_aD (ad-simplypeachy)]

Agreed. Panic from a warehouse being destroyed would be suitable :-)

[Nicolai Hähnle (nha)]

Let me put it this way: Who the hell cares about an orderly exit from a building that has just caught on fire? :P Also, it's a cute analogy to Settlers 2. Note that it is also consistent with what happens when you destroy other buildings.

We are bikeshedding here, but I vote to leave the behaviour as is.

[cghislai (charlyghislain)]

I vote for panic only if building is destroyed, but not dismantled.
Also, see 1144465 and 923702

[SirVer (sirver)]

sgtm.

[Hans Joachim Desserud (hjd)]

Bug 1144465 and bug 923702 ;)

[cghislai (charlyghislain)]

There is one issue that needs discussion...
Currently, all workers in stock are only freed if the warehouse is destroyed, leading the the explosion of carriers. I guess we all agree we should keep that. However, upon dismantling, currently only workers that are not yet incorporated in stock (such as soldiers) leave the building. So either we release all stock (maybe not carriers) when dismantling, either we don't release anything and rely on the player to empty it beforehand, either we only release soldiers. But the current behaviour is not straightforward imho.

[cghislai (charlyghislain)]

While i like the option to release all builders except carriers, it is a bit awkward to see 30 builders leaving the house and not a single one stopping to actually dismantle it...

[SirVer (sirver)]

Why? that is the way the system of Widelands works: everyone has his/her job and they never take the job of others. When there is no builder around, no one will dismantle the house. If none of them got the job, they will happily walk away - being glad that they where not chosen for the stupid task.

[SirVer (sirver)]

Released in build-18 rc1.