The BPM of short samples is wrong

[Alban]

The calculation used to compute the tempo of short samples use the number of beat marker instead of the number of beats, ie. it use beat.count() instead of (beat.count()-1).

[Daniel Schürmann (daschuer)]

Thank you for the patch. Your fix is fine from the logical side and because of no dependencies to other code it is suitable to be a last minute fix for 1.11.0.

However I cannot test the patch because my short samples below 12 beats have no beat grid at all.
How did you test it?

[Alban (albeu)]

On Tue, 02 Apr 2013 06:17:36 -0000
Daniel Schürmann <email address hidden> wrote:

> Thank you for the patch. Your fix is fine from the logical side and
> because of no dependencies to other code it is suitable to be a last
> minute fix for 1.11.0.
>
> However I cannot test the patch because my short samples below 12 beats have no beat grid at all.
> How did you test it?

I have some other changes to compute a "local" BPM that call this
function with only a few beats around the current play position. While
experiemting with this I noticed that the "local BPM" was way off what
is computed for the overall song, which I tracked to this.

I suppose with normal samples it's pretty hard to trigger. To test one
could increase N and use a sample having the same tempo overall.

Alban

[Daniel Schürmann (daschuer)]

Thank you Alban!
Commited to lp:mixxx/1.11 r3794

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6977