Pitch step of 0.01% aren't reloaded from the config

Bug #1162351 reported by Alban
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Alban

Bug Description

If a pitch step is set to the minimum possible value (0.01%) the value isn't applied on startup. This is because the values from the config file are applied by setting the value of the spinbox in the config dialog. However the spinbox have different default values than the controls they manipulate. As the spinbox optimize out calls to set which wouldn't change the value the backing control is not updated.

The attached patch fix this bug by setting the correct default value for the spinboxes.

Related branches

Revision history for this message
Alban (albeu) wrote :
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Alban (albeu)
status: Confirmed → In Progress
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi Alban,

Thank you for the patch!

There is a chance for a last minute commit to 1.11.0.

Before we do, though, please read and sign the Mixxx Contributor Agreement found here: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

Let us know when you have.

How is your real name that we could list in the contributor list?

Kind regards,

Daniel

Changed in mixxx:
milestone: none → 1.11.0
Revision history for this message
Alban (albeu) wrote : Re: [Bug 1162351] Re: Pitch step of 0.01% aren't reloaded from the config

On Sun, 31 Mar 2013 15:52:24 -0000
Daniel Schürmann <email address hidden> wrote:

> Hi Alban,
>
> Thank you for the patch!
>
> There is a chance for a last minute commit to 1.11.0.
>
> Before we do, though, please read and sign the Mixxx Contributor
> Agreement found here:
> https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
>
> Let us know when you have.

Done

> How is your real name that we could list in the contributor list?

Alban Bedel

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Thank you!
Committed lp:mixxx/1.11 revision 3792.

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6976

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.