[browser] Search action should be disabled if the address bar is empty
Bug #1161789 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app |
Fix Released
|
Medium
|
Renato Araujo Oliveira Filho | ||
Bug Description
Steps to reproduce (with the latest trunk):
1) Open the browser app
2) Reveal the toolbar
3) Click anywhere inside the address bar
4) Click the 'clear' button that appears to the right, the address bar is now empty
5) Click the action button to the left (a magnifying glass icon)
Expected result: nothing happens since the address bar is empty, in fact the action button should be disabled (and its icon greyed out).
Current result: google’s homepage is loaded (http://
Related branches
lp:~renatofilho/webbrowser-app/fix-1161789-2
- PS Jenkins bot: Approve (continuous-integration)
- Olivier Tilloy: Approve
-
Diff: 80 lines (+40/-2)3 files modifiedsrc/Ubuntu/Browser/AddressBar.qml (+4/-1)
tests/autopilot/webbrowser_app/emulators/main_window.py (+2/-1)
tests/autopilot/webbrowser_app/tests/test_addressbar_action_button.py (+34/-0)
| Changed in manhattan: | |
| status: | New → Confirmed |
| Changed in manhattan: | |
| assignee: | Olivier Tilloy (osomon) → Renato Araujo Oliveira Filho (renatofilho) |
| status: | Confirmed → In Progress |
| information type: | Proprietary → Public |
| affects: | manhattan → webbrowser-app |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in webbrowser-app: | |
| status: | In Progress → Fix Committed |
| Changed in webbrowser-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:webbrowser-app at revision 129, scheduled for release in webbrowser-app, milestone ubuntu-