Correctly handle an empty dnsmasq --domain

[Pádraig Brady]

https://review.openstack.org/#/c/25543/ made a change to pass single quotes in the option to dnsmasq.
Through quick code inspection this seems incorrect as the quotes will then become part of the domain name.
dnsmasq does handle _double_ quotes, but only in dnsmasq conf files and there they have special meaning for \t etc.

Note I've not actually tested the new code and would be very happy to be proved wrong here.

[Sean Dague (sdague)]

Just verified, for sure, that using the quotes on domain work fine. I expect that dnsmasq is actually filtering out the '' because they aren't valid dns domain values, so it's working fine, though probably not on purpose from a dnsmasq perspective.

I think the idea of fixing this more cleanly for havana to just drop that param to dnsmasq makes sense. would be a good clean up.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/25733

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/25733
Committed: http://github.com/openstack/nova/commit/24b9731af34fbc2fb17c849cb8cdb5c7a10db77d
Submitter: Jenkins
Branch: master

commit 24b9731af34fbc2fb17c849cb8cdb5c7a10db77d
Author: Pádraig Brady <email address hidden>
Date: Fri Mar 29 16:50:24 2013 +0000

    improve handling of an empty dnsmasq --domain

    Currently all domains passed through the dnsmasq --domain option,
    are single quoted. It's not fully understood how dnsmasq handles
    single quotes in this situation, so it's safer to just avoid the
    --domain option in this case.

    Fixes bug: 1161506
    Change-Id: I8ecd996676189f53908abd48fee81132091ee820

[Pádraig Brady (p-draigbrady)]

Seems this is a required fix.

Newer dnsmasq accept the single quotes, but there is no specific handling code for them.
I suspect they're being allowed to support IDN or something. Still expected behavior.

More problematically with some versions of dnsmasq (like 2.48-13 on RHEL (derivatives) for example),
dnsmasq will reject the single quotes and fail to start

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/26756

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/26756
Committed: http://github.com/openstack/nova/commit/3861f8c60cc46e9a00b06ca2bb8de91da8a22c6b
Submitter: Jenkins
Branch: stable/grizzly

commit 3861f8c60cc46e9a00b06ca2bb8de91da8a22c6b
Author: Pádraig Brady <email address hidden>
Date: Fri Mar 29 16:50:24 2013 +0000

    improve handling of an empty dnsmasq --domain

    Currently all domains passed through the dnsmasq --domain option,
    are single quoted. It's not fully understood how dnsmasq handles
    single quotes in this situation, so it's safer to just avoid the
    --domain option in this case.

    Fixes bug: 1161506
    Fixes bug: 1167447
    Change-Id: I8ecd996676189f53908abd48fee81132091ee820
    Cherry-picked: 24b9731af34fbc2fb17c849cb8cdb5c7a10db77d