"Binder" logic is redundant, unused and fails to build
Bug #1160741 reported by
Daniel van Vugt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Low
|
Daniel van Vugt | ||
Bug Description
Mir fails to build with -DMIR_TRANSPORT
Obviously that option hasn't worked in a while, if at all.
Please either remove the option and associated dead code, or make it buildable.
Related branches
lp:~vanvugt/mir/remove-binder
- Alan Griffiths: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 1093 lines (+0/-922)19 files modified3rd_party/android-deps/binder/IBinder.h (+0/-160)
CMakeLists.txt (+0/-7)
examples/CMakeLists.txt (+0/-6)
src/client/CMakeLists.txt (+0/-7)
src/client/make_binder_rpc_channel.cpp (+0/-29)
src/client/mir_binder_rpc_channel.cpp (+0/-139)
src/client/mir_binder_rpc_channel.h (+0/-71)
src/server/frontend/CMakeLists.txt (+0/-17)
src/server/frontend/binder_service.cpp (+0/-153)
src/server/frontend/binder_service.h (+0/-66)
src/server/frontend/make_protobuf_binder_communicator.cpp (+0/-38)
src/server/frontend/protobuf_binder_communicator.cpp (+0/-68)
src/server/frontend/protobuf_binder_communicator.h (+0/-51)
tests/acceptance-tests/CMakeLists.txt (+0/-5)
tests/mir_test_doubles/CMakeLists.txt (+0/-6)
tests/mir_test_doubles/test_protobuf_binder_server.cpp (+0/-37)
tests/mir_test_framework/CMakeLists.txt (+0/-6)
tests/mir_test_framework/binder_detect_server.cpp (+0/-54)
tests/unit-tests/frontend/CMakeLists.txt (+0/-2)
| description: | updated |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #1 |
| summary: |
- Mir fails to build with -DMIR_TRANSPORT=binder + "Binder" logic is redundant, unused and fails to build |
Revision history for this message
| Robert Ancell (robert-ancell) wrote | #2 |
| Changed in mir: | |
| assignee: | nobody → Daniel van Vugt (vanvugt) |
| Changed in mir: | |
| status: | New → Triaged |
| Changed in mir: | |
| status: | Triaged → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| milestone: | none → 0.0.3 |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
To clarify, I have no need or want for "binder" support. I just spent quite a while being confused because I noticed the *Binder* classes and was wondering what uses them. Apparently nothing does.