Add Preview column in Browse, and External Libraries views

Bug #1160525 reported by tomtom
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
Daniel Schürmann

Bug Description

The Preview-Deck and especially the Preview-Button besides every Track in Playlist- and Crates-Mode was very useful on the last Party. For emergency search it would be very helpful to have the Preview-Column also in Library- and Browser-Mode.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Thank you for the bug.
I can confirm that the preview column is missing in browse mode and in the external Libraries from iTunes and Rhythmbox.
The MIxxx Library has a preview column. Did you try to enable it via right kick on the header?

Changed in mixxx:
status: New → Confirmed
Revision history for this message
tomtom (thomas-8) wrote :

I found the preview column in library, it was disabled by default.

jus (jus)
summary: - Whishlist: Preview/Vorhören-Column in Library and Browse
+ Add Preview column in Browse, and External Libraries views
Changed in mixxx:
importance: Undecided → Wishlist
tags: added: whishlist
removed: whislist
tags: added: wishlist
removed: whishlist
Revision history for this message
Max Linke (max-linke) wrote :

This is a problem for people who are updating.

The old headerstate that doesn't know anything about the new column is saved in the database. Updating that string directly is hardly possible since it is encoding in a way I don't know. Scanning the qt documents I haven't found a way to access and manipulate the headerstate without constructing a Qtableview. We could add a message like the one for reanalysing the beatgrids

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi Max, thank you for your investigations.
I can not confirm that it is an issue from the stored header state.
This is only an separate issue that the preview column is not visible by default.

The man issue to me is that for instance ITunes has not preview column selectable.
Even if you start after renaming the .mixxx folder.

Revision history for this message
Max Linke (max-linke) wrote :

They both are part of this bug. A user who upgrades won't see the preview column as visible by default where it is available. For externaltracktabels there is actually a TODO in the code to add it.

 I can't add this because I don't understand some basic working of the Track Caching that we are doing. It is still strange for me that a query in librarytablemodel with preview added as "'' as preview" works to add the temporary view and why this query has to be done in the first place.

Revision history for this message
RAWRR (rawrr) wrote :

So Max, am I correct in extrapolating that completely uninstalling Mixxx and then reinstalling it will make the columns available in the views that are missing them? Because I do indeed tend to just install new versions right over old ones.

Revision history for this message
Max Linke (max-linke) wrote :

No it will not become available for browse view and external libraries because these views do not support the preview deck currently. The only thing this will do is show the columns by default in library/autodj/playlists/crates

Revision history for this message
RAWRR (rawrr) wrote :

So basically this is two separate problems with an only superficially similar symptom:

1. one, where columns are supposed to be available by default but instead are showing up as unselected, but which can still be selected by the user if wanted (Library, AutoDJ, Playlists, Crates)

2. another, where the columns aren't in the code in the first place (iTunes, Rhythmbox, Browse)

?

This is a question :)

Changed in mixxx:
milestone: none → 1.12.0
assignee: nobody → Daniel Schürmann (daschuer)
RAWRR (rawrr)
tags: added: columns library polish
removed: column wishlist
Max Linke (max-linke)
Changed in mixxx:
assignee: Daniel Schürmann (daschuer) → nobody
milestone: 1.12.0 → none
milestone: none → 1.13.0
Revision history for this message
Daniel Schürmann (daschuer) wrote :
Changed in mixxx:
status: Confirmed → In Progress
assignee: nobody → Daniel Schürmann (daschuer)
milestone: 2.1 → 1.12.0
Changed in mixxx:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6968

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.