router.interface.{create|delete} notifications do not include the router or tenant IDs

[Eoghan Glynn]

The router.interface.{create|delete} notifications are intended to be consumed by ceilometer, but do not include the router or tenant IDs in the RPC message payload. Ceilometer requires both these data for metering purposes.

Now the _context_tenant_id and _context_project_id are added by the notification layer, so ceilometer could conceivably use these instead. However for consistency with the other notifications emitted by quantum, the tenant ID should be included as a first-class entry in the payload.

Also the resource ID should be provided in the payload, in this case set to the router ID.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/25408

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/25408
Committed: http://github.com/openstack/quantum/commit/1daf927c9df046c17a8c3f07350f60cf488a4215
Submitter: Jenkins
Branch: master

commit 1daf927c9df046c17a8c3f07350f60cf488a4215
Author: Eoghan Glynn <email address hidden>
Date: Tue Mar 26 16:27:05 2013 +0000

    Add expected IDs to router.interface.* notifications

    Fixes bug 1160431

    The router.interface.{create|delete} notifications are intended to be
    consumed by ceilometer, but did not include the router or tenant IDs
    in the RPC message payload. Ceilometer requires both these data for
    metering purposes.

    The missing UUIDs are now provided in the notifications.

    Change-Id: I1ca6e1d5377100a0549293e0bdff0182711c750f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/26198

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/26198
Committed: http://github.com/openstack/quantum/commit/67292a7aac5f7eabc24f2d6d4fd5a8557dbe0068
Submitter: Jenkins
Branch: stable/grizzly

commit 67292a7aac5f7eabc24f2d6d4fd5a8557dbe0068
Author: Eoghan Glynn <email address hidden>
Date: Tue Mar 26 16:27:05 2013 +0000

    Add expected IDs to router.interface.* notifications

    Fixes bug 1160431

    The router.interface.{create|delete} notifications are intended to be
    consumed by ceilometer, but did not include the router or tenant IDs
    in the RPC message payload. Ceilometer requires both these data for
    metering purposes.

    The missing UUIDs are now provided in the notifications.

    Change-Id: I1ca6e1d5377100a0549293e0bdff0182711c750f

[Akihiro Motoki (amotoki)]

In the patch merged, tenant_id is retrieved from subnet. Is it better to use tenant_id from the port (i.e., interface)?

In usual case, tenant_id of subnet and port are same, but when a network is shared, tenant_id of the port is different from tenant_id from the subnet. This notification is related to the router interface, so I think tenant of the interface is better.