billing types in opensrf.xml are deprecated and should be removed from the opensrf.xml.example file

[Pasi Kallinen]

*EG master

See below for Bill Erickson's comment.

[Bill Erickson (berick)]

Hi Pasi, this bug should be changed (or a new one opened) to "billing types in opensrf.xml are deprecated and should be removed from the opensrf.xml.example file"

They have been replaced by the data in config.billing_type, which uses the standard in-db translation mechanism.

[Galen Charlton (gmc)]

The last remaining reference to the opensrf.xml billing_types list is the method open-ils.circ.billing_type.retrieve.all. There's no code in Evergreen that invokes that API call, so unless somebody knows of external clients of that method, it should be removed as well.

[Galen Charlton (gmc)]

A patch that removes billing_types from opensrf.xml.example (and the unused circ_modifier list) is available at the tip of the user/gmcharlt/lp1160343_remove_old_btype_list branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1160343_remove_old_btype_list

[Bill Erickson (berick)]

Tested and works. Thanks for the patch, Galen. Merged.