pt-query-digest 2.2 prints unwanted debug info on tcpdump parsing errors
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Brian Fraser |
Bug Description
Version 2.2.1 of pt-query-digest has a troubling regression compared to earlier versions where it will produce lots of unwanted debug output when it encounters errors in it's input.
-rw------- 1 root root 27M Mär 26 13:07 pt-query-
-rw------- 1 root root 15M Mär 26 13:03 pt-query-
-rw------- 1 root root 17M Mär 26 13:11 pt-query-
[..]
Session 192.168.2.58:43498 had errors, Reason: got an unexpected EOF packet, will save them in /tmp/pt-
Session 192.168.2.55:34050 had errors, Reason: got an unexpected EOF packet, will save them in /tmp/pt-
Session 192.168.2.220:34170 had errors, Reason: got an unexpected EOF packet, will save them in /tmp/pt-
Session 192.168.2.56:52370 had errors, Reason: got an unexpected EOF packet, will save them in /tmp/pt-
Session 192.168.3.71:37314 had errors, Reason: got an unexpected EOF packet, will save them in /tmp/pt-
[..]
This boils down to the fail_session rewrite in http://
The destined _no_save_error flag isn't hooked up anywhere and can't be used without hacking the source by hand.
Related branches
- Daniel Nichter: Approve
-
Diff: 307 lines (+105/-20)4 files modifiedbin/pt-query-digest (+27/-12)
bin/pt-upgrade (+18/-4)
lib/ProtocolParser.pm (+11/-2)
t/lib/MySQLProtocolParser.t (+49/-2)
Changed in percona-toolkit: | |
assignee: | nobody → Brian Fraser (fraserbn) |
tags: | added: spam |
Changed in percona-toolkit: | |
status: | Triaged → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
Thanks for reporting this. We did change how pqd handles tcpdump parsing errors in 2.2. We'll look into this and fix it soon in the next release, 2.2.2.