action.hold_request_cancel_cause entries not marked for translation

[Pasi Kallinen]

*EG master

action.hold_request_cancel_cause inserts are not marked with oils_i18n_gettext(), nor would they be picked up into po-files if they were, as they're not in 950.data.seed-values.sql

[Pasi Kallinen (paxed)]

Fix in user/paxed/lp1160270

[Remington Steed (rjs7)]

This bug is a duplicate of:

https://bugs.launchpad.net/evergreen/+bug/1107808

I have marked that as the duplicate, since this bug seems to have the better title. The submitted branches on each are essentially identical.

[Remington Steed (rjs7)]

Since this is a simple change, I have only done the basic test of running the SQL inserts in question, and they work as expected. Also, it is my understanding that this change does not require an upgrade script, because the upgrade process doesn't yet participate in the translation-building process. If this is true, then perhaps we should open a bug to address this.

I also resolved a merge conflict, for a commit that adds a new cancel cause "Patron via SIP". Signed off and rebased to master. Thanks Pasi!

lp1160270_action_i18n_seed_data

[Remington Steed (rjs7)]

Sorry, here's the full branch path:

user/rsteed/lp1160270_action_i18n_seed_data
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1160270_action_i18n_seed_data

[Dan Wells (dbw2)]

Picked back through 2.3. Thanks again, guys!