Mixxx

Colorschemes don't support new splitter/library/... widgets

Bug #1159451 reported by Max Linke on 2013-03-24

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mixxx	Fix Released	Medium	Max Linke	Mixxx 1.11.0

Bug Description

I've looked a bit into this. It seems that for the colorschemes to work we have to set the library style manually on the widgetgroup that contains the library. This patch does this. It looks better now in the outline800x400 skin but onw of the alternating colors is still off.

It would also be nice if someone could test if the previewdeck now can be skinned in outline.

Tags:

Related branches

lp:mixxx/1.11

Revision history for this message

Max Linke (max-linke) wrote on 2013-03-24:

colorscheme.patch Edit (2.2 KiB, text/plain)

jus (jus) on 2013-03-25

tags:	added: skin
Changed in mixxx:
importance:	Undecided → Medium

Revision history for this message

Max Linke (max-linke) wrote on 2013-03-25:

colorscheme_v2.patch Edit (11.0 KiB, text/plain)

here is a patch with the preview deck in the skin. It looks a bit cramped though

Revision history for this message

RJ Skerry-Ryan (rryan) wrote on 2013-03-27:

Thanks for working on this Max. Instead of auto-detecting the legacy library I prefer that we just make legacy skins have to add a tag to the <WidgetGroup> containing the <Splitter>. I added a fix based on your patch that uses <LegacyTableViewStyle> to indicate the legacy styling should occur. Committed to lp:mixxx/1.11.