beatloop_X_enabled should toggle anytime a loop of length X becomes active, not just beatloops

[rob]

It would be nice if the beatloop_X_enabled connectcontrol functions would fire anytime a loop of any kind of length X is active - ie: including manually set up loops using loop_in and loop_out or loops set up with scripts that don't use the beatloop_X_activate function. Currently, beatloop_X_enabled only responds to loops initiated with beatloop_X_activate.

I have a few looping functions which essentially are beatloops, but the start and end positions are calculated in script, because for some of the applications, the mixxx scripting interface can't do things as quickly as I need them done, so using beatloop_X_activate doesn't work - instead, I set the loop in and loop out and then activate the loop. But then my nice little beatloop indicator lights don't light up, which makes me extremely sad, because an indicator light that won't light is, as you will clearly realize, the worst possible thing that could happen in the universe.

[Daniel Schürmann (daschuer)]

Confirmed.

But It might be difficult in realization since a beat loop calculated from the script might not have the same precision behind the dot if we check for double type equal.
Maybe it is required to define a window, what is recognized as beat loop x or move some of you script logic to Mixxx itself.

If you are have scripting experience it should be not a big problem to do it your self. I would be happy to give you support.

[Be (be.ing)]

https://github.com/mixxxdj/mixxx/pull/1187

[Be (be.ing)]

Actually https://github.com/mixxxdj/mixxx/pull/1187 did not fully fix this. https://github.com/mixxxdj/mixxx/pull/1267 fixes it. Note that it will only work with loop_in/out if quantize is enabled so Mixxx can be sure the loop size is an exact number of beats (so we do not need an arbitrary window of tolerance that will inevitably be wrong sometimes).

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6958