Beatloop_activate should respect active loop in point

[rob]

I think that if a user has set up a loop with loop_in and loop_out (or any other way other than beatloop_activate), and that loop is active at the point when the user presses a beatloop_activate button, the newly activated beatloop should start at the loop_in point of the previously active loop.

Currently, it seems that beatloop_activate will start a beatloop at the current play position, regardless of whether a loop is currently active or not (in other words, the loop_in point will change if a beatloop is activated over a currently existing loop that was manually set up.) The only exception to this seems to be if the previously active loop was also initiated using beatloop_activate - in that case, the inpoint doesn't change.

[Daniel Schürmann (daschuer)]

Thank you for the report. Which Version of Mixxx is effected?
I either cannot reproduce it with Mixxx 1.11.0-pre and Ubuntu Precise or I have not got your point.
Can you give a step by step description to reproduce the issue.

[rob (another-rob)]

I'm using a recent build of Mixxx 1.11, but I think this would affect all earlier versions.

Press play on a track. Create a loop by pressing "loop in", then "loop out". Make it a nice long loop, so you can see what's happening easily. Let the play position get towards the end of the loop, and then activate a short beatloop... The new beatloop starts at the current play position, not at the former loop_in point. You can see this happening clearly by watching the waveform overview while you activate the beatloop.

[Daniel Schürmann (daschuer)]

Ah, Thank you for explaining. Now I can confirm, it is indeed inconsistent.

[rob (another-rob)]

Cool. Thanks. (The bug was set to "fix committed" - I'm assuming that was a mistake, so I changed it to confirmed.)

I think default behaviour for beatloops should probably be to start at the current play position if no loop is active, or at the currently active loop in point if a loop is active - so if the user activates different length beatloops one after the other, the loop length is changed by moving the loop_out point. (Except for not respecting manually set loop_in points as I've described above, this is the current behaviour).

It might also be interesting to provide a beatloop function that respects the end_point, and changes loop length by moving the in point. This might allow for a bit of a different effect.

[RJ Skerry-Ryan (rryan)]

Fixed in master.
https://github.com/mixxxdj/mixxx/commit/1449c8ea4816a95bb3dc1569858755275ebab7e1

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6957