Empty translatable string in 950.data.seed-values.sql

[Pasi Kallinen]

*EG master

     oils_i18n_gettext('circ.holds.default_shelf_expire_interval',
        '',
         'coust', 'description'),

The string in the middle line is empty, and will cause that to match the generic empty msgid in the po-file.

[Pasi Kallinen (paxed)]

As of commit f572768, the master stops rebuilding the db.seed.pot -file where this empty string is (around 25% mark) until this is fixed...

So here's a quick fix: user/paxed/lp1158211

[Dan Wells (dbw2)]

In the fix commit, the description given is:

'If this overlaps with a pickup library''s closed date, it is pushed out to the first open date. For example: "2 weeks" or "5 days"'

That seems nicely instructive, but maybe not actually descriptive enough? Or are you thinking the name is self-explanatory? What about something like:

'The amount of time an item will be held on the shelf before the hold expires. For example: "2 weeks" or "5 days"'

Something along those lines seems more in line with the other neighboring descriptions, I think (if I am even correct in what this setting does).

[Pasi Kallinen (paxed)]

Whatever works for you - I just pulled that description from the code comments for that setting...

[Pasi Kallinen (paxed)]

Changed the branch as per your suggestion, Dan.

[Remington Steed (rjs7)]

Tested by updating the description of the config.org_unit_setting_type on our test server, using the syntax in the provided branch. Works as expected. Rebased to master, signed off. Thanks Pasi!

user/rsteed/lp1158211_fill_empty_description

[Remington Steed (rjs7)]

Added new commit for missing upgrade script. Same branch.

[Pasi Kallinen (paxed)]

I completely forgot about the upgrade script. Thank you, Remington!

[Dan Wells (dbw2)]

Pushed to master and backported through rel_2_3. Thank you, Pasi and Remington!

[Dan Wells (dbw2)]

Hmmm, now that I have already pushed this, I am wondering, do we want the oils_i18n_gettext() in the upgrade script, too? Otherwise, upgrade scripters always get English.

I'll give it a try, but opinions are welcome as well. Thanks.

[Dan Wells (dbw2)]

Adding it worked fine, and seemed correct based on other upgrade scripts. Pushed.