Snapshot in-use count not decrement after snapshot is deleted

Bug #1157506 reported by terryg2012
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
John Griffith

Bug Description

The snapshot in-use count is not decremented after the snapshot has been deleted, thus leading to the following error:

ERROR: SnapshotLimitExceeded: Maximum number of snapshots allowed (10) exceeded

The version of cinder that I am using is:

root@cld4b1ubuntu:/etc/openstack-dashboard# dpkg --list |grep cinder
ii cinder-api 1:2013.1+git201303150944~precise-0ubuntu1 Cinder storage service - API server
ii cinder-common 1:2013.1+git201303150944~precise-0ubuntu1 Cinder storage service - common files
ii cinder-scheduler 1:2013.1+git201303150944~precise-0ubuntu1 Cinder storage service - Scheduler server
ii cinder-volume 1:2013.1+git201303150944~precise-0ubuntu1 Cinder storage service - Volume server
ii python-cinder 1:2013.1+git201303150944~precise-0ubuntu1 Cinder Python libraries
ii python-cinderclient 1:1.0.2.28.g020778d+git201303191431~precise-0ubuntu1 python bindings to the OpenStack Volume API
root@cld4b1ubuntu:/etc/openstack-dashboard#

Revision history for this message
John Griffith (john-griffith) wrote :

Yup, we're not doing any quota management on the delete here. Looking at this we should probably improve the quota management for volume_delete as well.

Changed in cinder:
status: New → Triaged
importance: Undecided → High
milestone: none → grizzly-rc2
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25012

Changed in cinder:
assignee: nobody → John Griffith (john-griffith)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/25012
Committed: http://github.com/openstack/cinder/commit/b450eef832ff471b78776c9715b0878e95d69263
Submitter: Jenkins
Branch: master

commit b450eef832ff471b78776c9715b0878e95d69263
Author: john-griffith <email address hidden>
Date: Thu Mar 21 09:48:03 2013 -0600

    Snapshot reservation sync calls wrong resource.

    The snapshot reservations code isn't calling the
    correct resource on sync (it's calling volumes). There's
    also some problems with the logic being used on the delete/clean up
    that are fixed here as well.

    Fixes bug: 1157506
    Fixes bug: 1157982

    Change-Id: I91327b8043ab63aa35ea8a91b6de544bf5bf6c61

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25220

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/25220
Committed: http://github.com/openstack/cinder/commit/5ffed5d2f71215de963c5a54e4f8a0ba48a05803
Submitter: Jenkins
Branch: milestone-proposed

commit 5ffed5d2f71215de963c5a54e4f8a0ba48a05803
Author: john-griffith <email address hidden>
Date: Thu Mar 21 09:48:03 2013 -0600

    Snapshot reservation sync calls wrong resource.

    The snapshot reservations code isn't calling the
    correct resource on sync (it's calling volumes). There's
    also some problems with the logic being used on the delete/clean up
    that are fixed here as well.

    Fixes bug: 1157506
    Fixes bug: 1157982

    Change-Id: I91327b8043ab63aa35ea8a91b6de544bf5bf6c61
    (cherry picked from commit b450eef832ff471b78776c9715b0878e95d69263)

Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-rc2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.