Allow translating more of the xul-interfaces

Bug #1157485 reported by Pasi Kallinen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

*EG master

This branch allows translating several previously untranslatable strings in xul-files. Most are in the serials interface.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/i18n-xul-values

Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 2.4.0-rc
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Revision history for this message
Remington Steed (rjs7) wrote :

The commit diff shows a number of apparently duplicate strings.

In the Serial Control View in the Subscriptions tab, some translatable strings appear twice in the code, but the strings are identical because they appear in identical menus (the "Actions for Selected Row" menu, and the context menu when you right-click on a row in the left list). So the following are duplicates that should be removed from this branch:

<!ENTITY staff.serial.manage_subs.cmd_add_sub.label "Add Subscription">
<!ENTITY staff.serial.manage_subs.cmd_add_sdist.label "Add Distribution">
<!ENTITY staff.serial.manage_subs.cmd_add_siss.label "Add Issuance">
<!ENTITY staff.serial.manage_subs.cmd_add_scap.label "Add Caption/Pattern">
<!ENTITY staff.serial.manage_subs.cmd_make_predictions.label "Make Predictions">
<!ENTITY staff.serial.manage_subs.cmd_del_ssub.label "Delete Subscription">
<!ENTITY staff.serial.manage_subs.cmd_del_sdist.label "Delete Distribution">
<!ENTITY staff.serial.manage_subs.cmd_del_siss.label "Delete Issuance">
<!ENTITY staff.serial.manage_subs.cmd_del_scap.label "Delete Caption/Pattern">

Thanks Pasi for all your work on this!

Revision history for this message
Pasi Kallinen (paxed) wrote :

I updated the branch, and removed the duplicates Remington Steed mentioned. Also added 13 strings I missed on the first round.

Revision history for this message
Jason Etheridge (phasefx) wrote :

Fix signed-off and committed to master, plus an additional fix.

109e8e0d584d57e3b1185681df723746899b439a
8c4192c71b361acd852f04866f8e5936e3d9be42

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.