Mir

demo_client_unaccelerated ignores stride

Bug #1157033 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Daniel van Vugt

Bug Description

demo_client_unaccelerated.c: region->stride is ignored, and _assumed_ to be 4*region->width.

static void render_pattern(MirGraphicsRegion *region, uint32_t pf)
{
    uint32_t *pixel = (uint32_t*) region->vaddr;

    int i,j;
    for(i=0; i< region->width; i++)
    {
        for(j=0; j<region->height; j++)
        {
            pixel[j*region->width + i] = pf;
        }
    }
}

Related branches

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also, the loops are inside-out, which makes memory access much slower.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 515, scheduled for release in mir, milestone 0.0.2

Changed in mir:
status: In Progress → Fix Committed
Changed in mir:
milestone: none → 0.0.3
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.