"rateRange" was not taken into account when changing rate slider by "bpm" control
Bug #1156319 reported by
Daniel Schürmann
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Low
|
Daniel Schürmann | ||
Bug Description
This was found by code review.
I think currently no script uses this feature but we should fix it just in case.
Related branches
lp:~mixxxdevelopers/mixxx/atomic-co
- Daniel Schürmann: Needs Fixing
- RJ Skerry-Ryan: Needs Fixing
-
Diff: 5303 lines (+2417/-1518)63 files modifiedmixxx/build/depends.py (+2/-3)
mixxx/res/controllers/Hercules DJ Console RMX 2.midi.xml (+963/-0)
mixxx/res/controllers/Hercules-DJ-Console-RMX-2-scripts.js (+128/-0)
mixxx/src/control/control.cpp (+132/-0)
mixxx/src/control/control.h (+95/-0)
mixxx/src/control/controlbehavior.cpp (+194/-0)
mixxx/src/control/controlbehavior.h (+97/-0)
mixxx/src/control/controlvalue.h (+157/-0)
mixxx/src/controlbeat.cpp (+0/-85)
mixxx/src/controlbeat.h (+0/-59)
mixxx/src/controllers/controller.h (+0/-2)
mixxx/src/controllers/controllerengine.cpp (+6/-11)
mixxx/src/controllers/controllermanager.cpp (+0/-4)
mixxx/src/controllers/controllermanager.h (+0/-1)
mixxx/src/controllers/midi/midicontroller.cpp (+5/-16)
mixxx/src/controllers/midi/midioutputhandler.cpp (+11/-20)
mixxx/src/controllers/midi/midioutputhandler.h (+2/-2)
mixxx/src/controllers/softtakeover.cpp (+1/-1)
mixxx/src/controllinpotmeter.cpp (+5/-24)
mixxx/src/controllinpotmeter.h (+1/-10)
mixxx/src/controllogpotmeter.cpp (+11/-87)
mixxx/src/controllogpotmeter.h (+3/-21)
mixxx/src/controlnull.cpp (+0/-27)
mixxx/src/controlnull.h (+0/-34)
mixxx/src/controlobject.cpp (+73/-317)
mixxx/src/controlobject.h (+49/-117)
mixxx/src/controlobjectthread.cpp (+40/-69)
mixxx/src/controlobjectthread.h (+33/-35)
mixxx/src/controlobjectthreadmain.cpp (+14/-14)
mixxx/src/controlobjectthreadmain.h (+9/-24)
mixxx/src/controlobjectthreadwidget.cpp (+33/-46)
mixxx/src/controlobjectthreadwidget.h (+7/-10)
mixxx/src/controlpotmeter.cpp (+68/-135)
mixxx/src/controlpotmeter.h (+10/-12)
mixxx/src/controlpushbutton.cpp (+22/-50)
mixxx/src/controlpushbutton.h (+1/-7)
mixxx/src/controlttrotary.cpp (+9/-27)
mixxx/src/controlttrotary.h (+2/-12)
mixxx/src/dlgprefeq.cpp (+4/-2)
mixxx/src/dlgprefeq.h (+1/-1)
mixxx/src/dlgtrackinfo.h (+9/-1)
mixxx/src/engine/bpmcontrol.cpp (+1/-1)
mixxx/src/engine/enginemaster.cpp (+0/-6)
mixxx/src/engine/enginemaster.h (+0/-1)
mixxx/src/engine/loopingcontrol.cpp (+41/-22)
mixxx/src/engine/ratecontrol.cpp (+10/-5)
mixxx/src/engine/syncworker.cpp (+0/-37)
mixxx/src/engine/syncworker.h (+0/-23)
mixxx/src/mixxx.cpp (+0/-7)
mixxx/src/mixxx.h (+0/-1)
mixxx/src/mixxxkeyboard.cpp (+2/-2)
mixxx/src/playermanager.cpp (+73/-44)
mixxx/src/playermanager.h (+17/-3)
mixxx/src/skin/legacyskinparser.cpp (+0/-10)
mixxx/src/skin/propertybinder.cpp (+1/-2)
mixxx/src/sounddeviceportaudio.cpp (+3/-2)
mixxx/src/soundmanager.cpp (+0/-6)
mixxx/src/soundmanager.h (+0/-2)
mixxx/src/vinylcontrol/vinylcontrolmanager.cpp (+10/-10)
mixxx/src/waveform/renderers/waveformmarkset.cpp (+2/-2)
mixxx/src/waveform/renderers/waveformrendererendoftrack.cpp (+1/-1)
mixxx/src/widget/wpushbutton.cpp (+2/-1)
mixxx/src/widget/wslidercomposed.cpp (+57/-44)
| summary: |
- "rateRange" was not taken into acount when changin rate slider by "bpm" - control + "rateRange" was not taken into account when changing rate slider by + "bpm" control |
| Changed in mixxx: | |
| status: | New → In Progress |
| assignee: | nobody → Daniel Schürmann (daschuer) |
| importance: | Undecided → Low |
Revision history for this message
| Daniel Schürmann (daschuer) wrote | #1 |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #2 |
Revision history for this message
| Daniel Schürmann (daschuer) wrote | #3 |
| Changed in mixxx: | |
| milestone: | none → 1.11.0 |
| status: | In Progress → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #4 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
The attached patch solves the problem, together with Bug #1156326 and some code clean up.