unexpected change in maintain_901()'s treatment of tcn_value

[Galen Charlton]

Commit 11903 (http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=119034544e2934f223ec71a63f884f1eed487d6a) rewrote the maintain_901() trigger function in Perl. However, a change in behavior is now apparent.

Prior to the rewrite, if the cat.bib.use_id_for_tcn global flag was set, the trigger function would set biblio.record_entry.tcn_value to the bre ID, then map that to the 901$a.

After the rewrite, it maps the bre ID to the 901$a, but doesn't update tcn_value. This is a problem if records are inserted directly into biblio.record_entry without explicitly setting tcn_value; in that case, it defaults to the value set by the biblio.next_autogen_tcn_value function. Since the intent of cat.bib.use_id_for_tcn flag is to force the TCN value to the bre ID, I prefer the prior behavior.

Evergreen master

[Galen Charlton (gmc)]

Patch with unwrapped DB update is available in the user/gmcharlt/lp1155329_tcn_value_forcing branch of the working/Evergreen repository: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1155329_tcn_value_forcing

[Ben Shum (bshum)]

Assigning targets since this change was present for 2.2+

[Ben Shum (bshum)]

Dan pushed this to master, rel_2_3, and rel_2_2. Thanks Galen and Dan!