Proximity adjustment UI default scoping change, unique constraint fix

Bug #1155312 reported by Lebbeous Fogle-Weekley
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

For 2.4+

1) UI change - pre-select highest OU where user can edit

There's a dropdown in the org unit proximity adjustment interface that
affects the scope of what you can see in the table below. Before, that
dropdown would be set to the user's home UO (say, BR1 in the example org
tree). But you might have the permission to make changes everywhere, so
you add a proximity adjustment that affects BR3 in some way. As soon as
you'd refresh the interface, your new proximity adjustment would not be
visible, because your scope selector would default to BR1.

So now the dropdown defaults to the first context where you have the
permission, which in all but eccentric setups should be the highest OU
(and therefore broadest scope) where you have the permission.

This could also improve other interfaces in the future. Anything that
invokes openils.User.buildPermOrgSelector() can pass -1 as the third
parameter to get the new behavior.

2) Change UNIQUE index at DB layer.

This prevents the creation of rows that would give the hold targeter
conflicting directives.
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/prox-tweaks

Tags: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Assigning target for this bug fix.

Changed in evergreen:
milestone: none → 2.4.0-beta
status: New → Confirmed
importance: Undecided → Medium
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Revision history for this message
Mike Rylander (mrylander) wrote :

The constraint part seems most important from a correctness standpoint, but the UI bit will help reduce frustration, so is included. Thanks, Lebbeous!

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.