Glance v2 API changes its behavior based on the is_public filter even tho that is not a valid optins in v2.

Bug #1154760 reported by John Bresnahan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Mark Washenberger

Bug Description

The v2 API changed its filter options from accepting the is_public filter to the visibility option. However, when the index request is received with the is_public= query parameter it alters the behavior of the service.

The v2 API should validate all parameters and throw an error if any invalid parameters are received.

Alex Meade (alex-meade)
Changed in glance:
status: New → Confirmed
importance: Undecided → Low
tags: added: grizzly-rc-potential
Changed in glance:
status: Confirmed → Triaged
Changed in glance:
assignee: nobody → John Bresnahan (jbresnah)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25089

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/25190

Changed in glance:
assignee: John Bresnahan (jbresnah) → Mark Washenberger (markwash)
Thierry Carrez (ttx)
tags: added: grizzly-backport-potential
removed: grizzly-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/25190
Committed: http://github.com/openstack/glance/commit/d8e3f873e01280d49602ce87bed4d1e08ff07640
Submitter: Jenkins
Branch: master

commit d8e3f873e01280d49602ce87bed4d1e08ff07640
Author: Mark J. Washenberger <email address hidden>
Date: Fri Mar 22 10:59:28 2013 -0700

    Make is_public an argument rather than a filter.

    There is disagreement between the v1 api and v2 api about what an
    'is_public' filter ought to mean. Version 1 uses 'is_public'
    to filter whether or not image.is_public == True or False. Version 2
    uses 'visibility' for this purpose. But in addition, it is theoretically
    possible that 'is_public' is a valid property filter in v2.

    With this change, v1 can pass is_public in as an argument to
    image_get_all. V2 will continue to pass is_public through filters.

    fixes bug: 1157988
    fixes bug: 1154760

    Change-Id: I716cb8b4f207f8526125ed360f5a24a6630c1e67

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: havana-1 → 2013.2
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.