During a workshop over the past few days, multiple users have reported strange bugs related to input reuse. Here are the facts:
* --force-inputs is `false` by default
* this means that by default, we attempt to reuse inputs
* if a user experiences an error with a source (for example, with bad geometry), they will correct the error and re-run the calculation
* if they don't change the filename of the source model in the source model logic tree file, the inputs are considered to be the same and the old (broken) set of inputs will be reused
* this is very confusing for the users
I think we should remove this feature before the v1.0 release. That means, remove the command line option and also remove the functionality from the engine which deals with identical inputs. We've had way too many bugs with this just in the last few months, and now it's really starting to affect users. We should just get rid of it and replace it with a more well thought out mechanism to reuse inputs from the database. I have drafted a blueprint for this work: https://blueprints.launchpad.net/openquake/+spec/reuse-db-input-models
Pull request: https:/